Command Bars - Circuitous to change textcolor for status bar

Print Page | Close Window

Circuitous to change textcolor for status bar

Printed From: Codejock Forums
Category: Codejock Products
Forum Name: Command Bars
Forum Description: Topics Related to Codejock Command Bars
URL: http://forum.codejock.com/forum_posts.asp?TID=22237
Printed Date: 28 November 2024 at 10:04am
Software Version: Web Wiz Forums 12.04 - http://www.webwizforums.com

Topic: Circuitous to change textcolor for status bar

Posted By: Michl
Subject: Circuitous to change textcolor for status bar
Date Posted: 13 March 2014 at 10:50am

I have found a new code section which could be improvemened.

The change of the background color and the text color for a office 2013 status bar is not as easy as it should be.
The class CXTPCommandBarsOffice2013Theme contains 2 members.

- m_clrStatusBarBackground
- m_clrStatusTextColor

But due to an incomprehensible implementation is ignored m_clrStatusTextColor.


COLORREF CXTPStatusBarThemeOffice2013::GetTextColor(CXTPStatusBarPane *pPane)
{
    UNUSED_ALWAYS(pPane);
    return RGB(255,255,255);
}

The method is overridden an the return value of text color is hard coded although m_clrStatusTextColor contains already white. Is this override really necessary??
I suggest to change method to


return m_pPaintManager->m_clrStatusTextColor;