Codejock Forums Homepage
Forum Home Forum Home > Codejock Products > Visual C++ MFC > Command Bars
  New Posts New Posts RSS Feed - Circuitous to change textcolor for status bar
  FAQ FAQ  Forum Search   Events   Register Register  Login Login

Circuitous to change textcolor for status bar

 Post Reply Post Reply
Author
Message
Michl View Drop Down
Senior Member
Senior Member


Joined: 14 September 2007
Status: Offline
Points: 138
Post Options Post Options   Thanks (0) Thanks(0)   Quote Michl Quote  Post ReplyReply Direct Link To This Post Topic: Circuitous to change textcolor for status bar
    Posted: 13 March 2014 at 10:50am
I have found a new code section which could be improvemened.

The change of the background color and the text color for a office 2013 status bar is not as easy as it should be.
The class CXTPCommandBarsOffice2013Theme contains 2 members.

- m_clrStatusBarBackground
- m_clrStatusTextColor


But due to an incomprehensible implementation is ignored m_clrStatusTextColor.

COLORREF CXTPStatusBarThemeOffice2013::GetTextColor(CXTPStatusBarPane *pPane)
{
    UNUSED_ALWAYS(pPane);
    return RGB(255,255,255);
}


The method is overridden an the return value of text color is hard coded although m_clrStatusTextColor contains already white. Is this override really necessary??
I suggest to change method to

return m_pPaintManager->m_clrStatusTextColor;

Back to Top
 Post Reply Post Reply
  Share Topic   

Forum Jump Forum Permissions View Drop Down



This page was generated in 0.047 seconds.