Codejock Forums Homepage
Forum Home Forum Home > Codejock Products > Visual C++ MFC > Skin Framework
  New Posts New Posts RSS Feed - CXTPSkinManagerLegacyApiHook::OnHookGetSysColor()
  FAQ FAQ  Forum Search   Events   Register Register  Login Login

CXTPSkinManagerLegacyApiHook::OnHookGetSysColor()

 Post Reply Post Reply
Author
Message
MaxG View Drop Down
Newbie
Newbie


Joined: 10 February 2021
Status: Offline
Points: 2
Post Options Post Options   Thanks (0) Thanks(0)   Quote MaxG Quote  Post ReplyReply Direct Link To This Post Topic: CXTPSkinManagerLegacyApiHook::OnHookGetSysColor()
    Posted: 10 February 2021 at 4:03am
Hello!
I believe there's a bug in Toolkit for MFC v19.3.0 in CXTPSkinManagerLegacyApiHook::OnHookGetSysColor():

original:
CXTPSkinManagerMetrics* pMetrics = XTPSkinManager()->GetMetrics();
if (NULL != pMetrics && pSkinManager->IsEnabled())
{
crColor    = pMetrics->GetColor(nIndex);
bDefaultProcessing = (COLORREF_NULL != crColor);
}

expected:
CXTPSkinManagerMetrics* pMetrics = XTPSkinManager()->GetMetrics();
if (NULL != pMetrics && pSkinManager->IsEnabled())
{
crColor    = pMetrics->GetColor(nIndex);
bDefaultProcessing = (COLORREF_NULL == crColor);
}

So there should be == operator when comparing retrieved color to COLORREF_NULL. Otherwise, themed colors are replaced with the system colors.

Thanks!
Back to Top
 Post Reply Post Reply
  Share Topic   

Forum Jump Forum Permissions View Drop Down

Forum Software by Web Wiz Forums® version 12.04
Copyright ©2001-2021 Web Wiz Ltd.

This page was generated in 0.125 seconds.