Codejock Developer Community : CXTPSkinManagerLegacyApiHook::OnHookGetSysColor() http://forum.codejock.com/ Copyright (c) 2006-2013 Web Wiz Forums - All Rights Reserved. Sun, 05 Apr 2026 10:43:14 +0000 Wed, 10 Feb 2021 04:03:44 +0000 http://blogs.law.harvard.edu/tech/rss Web Wiz Forums 12.04 360 forum.codejock.com/RSS_post_feed.asp?TID=24131 <![CDATA[Codejock Developer Community]]> http://forum.codejock.com/forum_images/codejock-logo.gif http://forum.codejock.com/ <![CDATA[CXTPSkinManagerLegacyApiHook::OnHookGetSysColor() : Hello!I believe there&#039;s a...]]> http://forum.codejock.com/forum_posts.asp?TID=24131&PID=78043&title=cxtpskinmanagerlegacyapihookonhookgetsyscolor#78043 Author: MaxG
Subject: 24131
Posted: 10 February 2021 at 4:03am

Hello!
I believe there's a bug in Toolkit for MFC v19.3.0 in CXTPSkinManagerLegacyApiHook::OnHookGetSysColor():

original:
CXTPSkinManagerMetrics* pMetrics = XTPSkinManager()->GetMetrics();
if (NULL != pMetrics && pSkinManager->IsEnabled())
{
crColor    = pMetrics->GetColor(nIndex);
bDefaultProcessing = (COLORREF_NULL != crColor);
}

expected:
CXTPSkinManagerMetrics* pMetrics = XTPSkinManager()->GetMetrics();
if (NULL != pMetrics && pSkinManager->IsEnabled())
{
crColor    = pMetrics->GetColor(nIndex);
bDefaultProcessing = (COLORREF_NULL == crColor);
}

So there should be == operator when comparing retrieved color to COLORREF_NULL. Otherwise, themed colors are replaced with the system colors.

Thanks!
]]> Wed, 10 Feb 2021 04:03:44 +0000 http://forum.codejock.com/forum_posts.asp?TID=24131&PID=78043&title=cxtpskinmanagerlegacyapihookonhookgetsyscolor#78043