SIgnature suggestion for ...::SetValue()

Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic


   Hi,
 
CXTPPropertyGridItem::SetValue is declared as
 
virtual void CXTPPropertyGridItem::SetValue(CString strValue)
 
I suggest to change it to
 

virtual void CXTPPropertyGridItem::SetValue(const CString& strValue)

Author	Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic
mgampi Members Profile Send Private Message Find Members Posts Add to Buddy List Senior Member Joined: 14 July 2003 Status: Offline Points: 1198	Post Options Post Reply Quote mgampi Report Post Thanks(0) Quote Reply Topic: SIgnature suggestion for ...::SetValue() Posted: 02 May 2008 at 8:02am
	Hi, CXTPPropertyGridItem::SetValue is declared as virtual void CXTPPropertyGridItem::SetValue(CString strValue) I suggest to change it to virtual void CXTPPropertyGridItem::SetValue(const CString& strValue)
	Martin Product: Xtreme Toolkit v 19.0.0, new Projects v 19.1.0 Platform: Windows 10 v 1909 (64bit) Language: VC++ 2017

jimmy Members Profile Send Private Message Find Members Posts Add to Buddy List Senior Member Joined: 11 November 2003 Location: Austria Status: Offline Points: 515	Post Options Post Reply Quote jimmy Report Post Thanks(0) Quote Reply Posted: 02 May 2008 at 8:31am
	Hello, I also prefered this. But Codejock have cange many calls from Fkt(CString strText) to Fkt(LPCTSTR lpText) and not to Ftk(const CString& strText). i don't know why ? 98 percent of CString parameter call in our project come from a other CString and not from a const string "MyText". Jimmy