CXTPSkinManagerLegacyApiHook::OnHookGetSysColor()

Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic

   Hello!I believe there's a bug in Toolkit for MFC v19.3.0 in CXTPSkinManagerLegacyApiHook::OnHookGetSysColor():
original:
CXTPSkinManagerMetrics* pMetrics = XTPSkinManager()->GetMetrics();
if (NULL != pMetrics && pSkinManager->IsEnabled())
{
	crColor		   = pMetrics->GetColor(nIndex);
	bDefaultProcessing = (COLORREF_NULL != crColor);
}

expected:
CXTPSkinManagerMetrics* pMetrics = XTPSkinManager()->GetMetrics();
if (NULL != pMetrics && pSkinManager->IsEnabled())
{
	crColor		   = pMetrics->GetColor(nIndex);
	bDefaultProcessing = (COLORREF_NULL == crColor);
}

So there should be == operator when comparing retrieved color to COLORREF_NULL. Otherwise, themed colors are replaced with the system colors.

Thanks!

Author	Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic
MaxG Members Profile Send Private Message Find Members Posts Add to Buddy List Newbie Joined: 10 February 2021 Status: Offline Points: 2	Post Options Post Reply Quote MaxG Report Post Thanks(0) Quote Reply Topic: CXTPSkinManagerLegacyApiHook::OnHookGetSysColor() Posted: 10 February 2021 at 4:03am
	Hello! I believe there's a bug in Toolkit for MFC v19.3.0 in CXTPSkinManagerLegacyApiHook::OnHookGetSysColor(): original: CXTPSkinManagerMetrics* pMetrics = XTPSkinManager()->GetMetrics(); if (NULL != pMetrics && pSkinManager->IsEnabled()) { crColor = pMetrics->GetColor(nIndex); bDefaultProcessing = (COLORREF_NULL != crColor); } expected: CXTPSkinManagerMetrics* pMetrics = XTPSkinManager()->GetMetrics(); if (NULL != pMetrics && pSkinManager->IsEnabled()) { crColor = pMetrics->GetColor(nIndex); bDefaultProcessing = (COLORREF_NULL == crColor); } So there should be == operator when comparing retrieved color to COLORREF_NULL. Otherwise, themed colors are replaced with the system colors. Thanks!