Circuitous to change textcolor for status bar

Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic

   I have found a new code section which could be improvemened.

The change of the background color and the text color for a office 2013 status bar is not as easy as it should be.
The class CXTPCommandBarsOffice2013Theme contains 2 members.

- m_clrStatusBarBackground
- m_clrStatusTextColor

But due to an incomprehensible implementation is ignored m_clrStatusTextColor.

COLORREF CXTPStatusBarThemeOffice2013::GetTextColor(CXTPStatusBarPane *pPane)
{
    UNUSED_ALWAYS(pPane);
    return RGB(255,255,255);
}

The method is overridden an the return value of text color is hard coded although m_clrStatusTextColor contains already white. Is this override really necessary??
I suggest to change method to

return m_pPaintManager->m_clrStatusTextColor;