Changing signature of virtual functions breaks all

Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic

   Hi
When you guys change the signature of a virtual, if we have overridden it, we don't get called any more.  So changing the signature introduces a heap of bugs for us.

In CXTPPropertyGridItem, the prototype for OnValueChanged went from void OnValueChanged(CString strValue) to void OnValueChanged(const CString& strValue).

Consequently any place where we over-rode custom property grid item objects for special cases, no longer work.

This is really really dangerous, and there should be a big warning somewhere about it.

The sort of bugs it creates are hard to find, and we don't expect to have to fully regression test everything on every CJ update.

C'mon guys help us out here.

Author	Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic
adrien Members Profile Send Private Message Find Members Posts Add to Buddy List Senior Member Joined: 30 April 2007 Location: New Zealand Status: Offline Points: 449	Post Options Post Reply Quote adrien Report Post Thanks(0) Quote Reply Topic: Changing signature of virtual functions breaks all Posted: 01 August 2012 at 7:51pm
	Hi When you guys change the signature of a virtual, if we have overridden it, we don't get called any more. So changing the signature introduces a heap of bugs for us. In CXTPPropertyGridItem, the prototype for OnValueChanged went from void OnValueChanged(CString strValue) to void OnValueChanged(const CString& strValue). Consequently any place where we over-rode custom property grid item objects for special cases, no longer work. This is really really dangerous, and there should be a big warning somewhere about it. The sort of bugs it creates are hard to find, and we don't expect to have to fully regression test everything on every CJ update. C'mon guys help us out here.
	http://www.wingate.com