Toolkit Pro - Changing signature of virtual functions breaks all

Print Page | Close Window

Changing signature of virtual functions breaks all

Printed From: Codejock Forums
Category: Codejock Products
Forum Name: Toolkit Pro
Forum Description: Topics Related to Codejock Toolkit Pro
URL: http://forum.codejock.com/forum_posts.asp?TID=20010
Printed Date: 09 May 2025 at 11:45am
Software Version: Web Wiz Forums 12.04 - http://www.webwizforums.com

Topic: Changing signature of virtual functions breaks all

Posted By: adrien
Subject: Changing signature of virtual functions breaks all
Date Posted: 01 August 2012 at 7:51pm

When you guys change the signature of a virtual, if we have overridden it, we don't get called any more. So changing the signature introduces a heap of bugs for us.

In CXTPPropertyGridItem, the prototype for OnValueChanged went from void OnValueChanged(CString strValue) to void OnValueChanged(const CString& strValue).

Consequently any place where we over-rode custom property grid item objects for special cases, no longer work.

This is really really dangerous, and there should be a big warning somewhere about it.

The sort of bugs it creates are hard to find, and we don't expect to have to fully regression test everything on every CJ update.

C'mon guys help us out here.

-------------
http://www.wingate.com - http://www.wingate.com