Bug in OnHookLoadLibrary()

Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic

   We just found out that CXTPSkinManagerApiHook's methods for hooking LoadLibrary() can accidentally change the GetLastError() value returned by system. To overcome some problems this caused to our application, we needed to fix XTP code like this:

HMODULE WINAPI CXTPSkinManagerApiHook::OnHookLoadLibraryW(PCWSTR pszModuleName)
{
    typedef HMODULE (WINAPI* LPFNLOADLIBRARYW)(PCWSTR pszModuleName);

    PROC pfnOrig = GetOriginalProc(xtpSkinApiLoadLibraryW);
    if (!pfnOrig)
        return ::LoadLibraryW(pszModuleName);

    HMODULE hmod = ((LPFNLOADLIBRARYW)pfnOrig)(pszModuleName);

    // Added test for hmod: the fn. HackModuleOnLoad() can be called only when
    // hmod is not-NULL, it means the module (some dll) was successfully loaded.
    // Otherwise the global 'last error value' could be changed.
    if (hmod)
        GetInstance()->HackModuleOnLoad(hmod, 0);

    return hmod;
}

Can you please add this fix to your future releases, on all code places where relevant? Thank you.

It's the same case at least with the following functions:
CXTPSkinManagerApiHook::OnHookLoadLibraryA()
CXTPSkinManagerApiHook::OnHookLoadLibraryW()
CXTPSkinManagerApiHook::OnHookLoadLibraryExA()
CXTPSkinManagerApiHook::OnHookLoadLibraryExW()
CXTPSkinManagerApiHook::OnHookLoadLibraryEx2W()