Codejock Developer Community : Bug in OnHookLoadLibrary() http://forum.codejock.com/ Copyright (c) 2006-2013 Web Wiz Forums - All Rights Reserved. Sun, 05 Apr 2026 16:44:49 +0000 Tue, 21 Aug 2012 12:09:59 +0000 http://blogs.law.harvard.edu/tech/rss Web Wiz Forums 12.04 360 forum.codejock.com/RSS_post_feed.asp?TID=20071 <![CDATA[Codejock Developer Community]]> http://forum.codejock.com/forum_images/codejock-logo.gif http://forum.codejock.com/ <![CDATA[Bug in OnHookLoadLibrary() : akur wrote:Can you please...]]> http://forum.codejock.com/forum_posts.asp?TID=20071&PID=68807&title=bug-in-onhookloadlibrary#68807 Author: ABuenger
Subject: 20071
Posted: 21 August 2012 at 12:09pm

Originally posted by akur akur wrote:

Can you please add this fix to your future releases, on all code places where relevant? Thank you.

It's the same case at least with the following functions:
CXTPSkinManagerApiHook::OnHookLoadLibraryA()
CXTPSkinManagerApiHook::OnHookLoadLibraryW()
CXTPSkinManagerApiHook::OnHookLoadLibraryExA()
CXTPSkinManagerApiHook::OnHookLoadLibraryExW()
CXTPSkinManagerApiHook::OnHookLoadLibraryEx2W()


Hi,

check added for next release.

Andre

]]> Tue, 21 Aug 2012 12:09:59 +0000 http://forum.codejock.com/forum_posts.asp?TID=20071&PID=68807&title=bug-in-onhookloadlibrary#68807 <![CDATA[Bug in OnHookLoadLibrary() : We just found out thatCXTPSkinManagerApiHook&#039;s...]]> http://forum.codejock.com/forum_posts.asp?TID=20071&PID=68797&title=bug-in-onhookloadlibrary#68797 Author: akur
Subject: 20071
Posted: 21 August 2012 at 1:52am

We just found out that CXTPSkinManagerApiHook's methods for hooking LoadLibrary() can accidentally change the GetLastError() value returned by system. To overcome some problems this caused to our application, we needed to fix XTP code like this:

HMODULE WINAPI CXTPSkinManagerApiHook::OnHookLoadLibraryW(PCWSTR pszModuleName)
{
    typedef HMODULE (WINAPI* LPFNLOADLIBRARYW)(PCWSTR pszModuleName);

    PROC pfnOrig = GetOriginalProc(xtpSkinApiLoadLibraryW);
    if (!pfnOrig)
        return ::LoadLibraryW(pszModuleName);

    HMODULE hmod = ((LPFNLOADLIBRARYW)pfnOrig)(pszModuleName);

    // Added test for hmod: the fn. HackModuleOnLoad() can be called only when
    // hmod is not-NULL, it means the module (some dll) was successfully loaded.
    // Otherwise the global 'last error value' could be changed.
    if (hmod)
        GetInstance()->HackModuleOnLoad(hmod, 0);

    return hmod;
}

Can you please add this fix to your future releases, on all code places where relevant? Thank you.

It's the same case at least with the following functions:
CXTPSkinManagerApiHook::OnHookLoadLibraryA()
CXTPSkinManagerApiHook::OnHookLoadLibraryW()
CXTPSkinManagerApiHook::OnHookLoadLibraryExA()
CXTPSkinManagerApiHook::OnHookLoadLibraryExW()
CXTPSkinManagerApiHook::OnHookLoadLibraryEx2W()

]]> Tue, 21 Aug 2012 01:52:49 +0000 http://forum.codejock.com/forum_posts.asp?TID=20071&PID=68797&title=bug-in-onhookloadlibrary#68797