|
Virtual OnValueChanged arguments changed |
Post Reply 
|
| Author | |
cpede 
Senior Member 
Joined: 13 August 2004 Location: Denmark Status: Offline Points: 680 |
 Post Options
 Thanks(0)
 Quote Reply
 Topic: Virtual OnValueChanged arguments changedPosted: 20 June 2012 at 10:06am |
|
Aggg, you just changed the virtual method from:
virtual void OnValueChanged(CString strValue); in v15.2.1, to
virtual void OnValueChanged(const CString &strValue);
in v15.3.1, WITHOUT WRITING IT IN THE RELEASE NOTES.
This of cause breaks all existing code without any compiler warnings etc.
-cpede
|
|
|
Product: Xtreme ToolkitPro (24.0.0)
Platform: Windows 10 (x64) Language: Visual Studio 2017 (C++) |
|
 |
|
|
SuperMario
Admin Group 
Joined: 14 February 2004 Status: Offline Points: 18057 |
Post Options
Thanks(0)
Quote Reply
Posted: 21 June 2012 at 3:01pm |
|
Thanks, the changes have been reverted for the next release so you can still use your existing code. void CXTPPropertyGridItem::OnValueChanged(CString strValue) |
|
|
|
|
adrien
Senior Member
Joined: 30 April 2007 Location: New Zealand Status: Offline Points: 449 |
Post Options
Thanks(0)
Quote Reply
Posted: 01 August 2012 at 8:04pm |
|
I Just got bitten by this, we will have to re-release all our products.
These things are not obvious in testing. You don't expect a property grid item to stop working, it still looks ok. If you change it back, that's just going to mean we have to re-change all our code back again - we already fixed it up. So please just leave it.
|
|
|
|
|
cpede
Senior Member
Joined: 13 August 2004 Location: Denmark Status: Offline Points: 680 |
Post Options
Thanks(0)
Quote Reply
Posted: 20 August 2012 at 10:08am |
|
Agree...
|
|
|
Product: Xtreme ToolkitPro (24.0.0)
Platform: Windows 10 (x64) Language: Visual Studio 2017 (C++) |
|
|
|
|
apautrot
Groupie 
Joined: 16 April 2009 Location: France Status: Offline Points: 18 |
Post Options
Thanks(0)
Quote Reply
Posted: 24 August 2012 at 4:53am |
|
Yeah I was about to post about that.
"Thanks, the changes have been reverted for the next release so you can still use your existing code." And so we will have to re-change all the calls again... you should stick to the change once for all.
|
|
|
Win 7 x64 VS 2008 CJ 15.13 |
|
|
|
|
MarkWoodard
Newbie 
Joined: 14 November 2007 Location: United States Status: Offline Points: 2 |
Post Options
Thanks(0)
Quote Reply
Posted: 30 September 2012 at 12:23pm |
|
CodeJock even broke some of their own code with this change: CXTPPropertyGridItemSize and CSTPPropertyGridItemPoint no longer work correctly, and who knows how many other property items of theirs?
|
|
|
|
|
MarkWoodard
Newbie
Joined: 14 November 2007 Location: United States Status: Offline Points: 2 |
Post Options
Thanks(0)
Quote Reply
Posted: 30 September 2012 at 12:39pm |
|
OK, I haven't tested all of these, but I'm sure they are all unhealthy, because they all use the incorrect override of OnValueChanged.
CXTPPropertyGridItemFlags
CXTPPropertyGridItemDate
CXTPPropertyGridItemSize
CXTPPropertyGridItemPoint
This obvious fix is to fix the method signatures and recompile the libraries.
 |
|
|
|
|
Fredrik
Senior Member
Joined: 22 June 2005 Status: Offline Points: 235 |
Post Options
Thanks(0)
Quote Reply
Posted: 08 October 2012 at 6:59am |
|
> Thanks, the changes have been reverted for the next release so you can still use your existing code. > virtual void OnValueChanged(CString strValue);> void CXTPPropertyGridItem::OnValueChanged(CString strValue) When is the next release? Is the decision still that this change will be reverted in the next release?
|
|
|
Windows 10, Visual Studio 20157, Toolkit Pro 18.3.0
|
|
|
|
|
Post Reply
|
|
Tweet
|
| Forum Jump | Forum Permissions You cannot post new topics in this forum You cannot reply to topics in this forum You cannot delete your posts in this forum You cannot edit your posts in this forum You cannot create polls in this forum You cannot vote in polls in this forum |
Topic Options