Codejock Developer Community : Virtual OnValueChanged arguments changed http://forum.codejock.com/ Copyright (c) 2006-2013 Web Wiz Forums - All Rights Reserved. Sat, 06 Jun 2026 21:09:05 +0000 Mon, 08 Oct 2012 06:59:49 +0000 http://blogs.law.harvard.edu/tech/rss Web Wiz Forums 12.04 360 forum.codejock.com/RSS_post_feed.asp?TID=19884 <![CDATA[Codejock Developer Community]]> http://forum.codejock.com/forum_images/codejock-logo.gif http://forum.codejock.com/ <![CDATA[Virtual OnValueChanged arguments changed : &gt; Thanks, the changes have...]]> http://forum.codejock.com/forum_posts.asp?TID=19884&PID=69045&title=virtual-onvaluechanged-arguments-changed#69045 Author: Fredrik
Subject: 19884
Posted: 08 October 2012 at 6:59am

> Thanks, the changes have been reverted for the next release so you can still use your existing code.
> virtual void OnValueChanged(CString strValue);
> void CXTPPropertyGridItem::OnValueChanged(CString strValue)

When is the next release? Is the decision still that this change will be reverted in the next release? 
]]> Mon, 08 Oct 2012 06:59:49 +0000 http://forum.codejock.com/forum_posts.asp?TID=19884&PID=69045&title=virtual-onvaluechanged-arguments-changed#69045 <![CDATA[Virtual OnValueChanged arguments changed : OK, I haven&#039;t tested all...]]> http://forum.codejock.com/forum_posts.asp?TID=19884&PID=69009&title=virtual-onvaluechanged-arguments-changed#69009 Author: MarkWoodard
Subject: 19884
Posted: 30 September 2012 at 12:39pm

OK, I haven't tested all of these, but I'm sure they are all unhealthy, because they all use the incorrect override of OnValueChanged.
 
CXTPPropertyGridItemFlags
CXTPPropertyGridItemDate
CXTPPropertyGridItemSize
CXTPPropertyGridItemPoint
 
This obvious fix is to fix the method signatures and recompile the libraries. Ouch
]]> Sun, 30 Sep 2012 12:39:04 +0000 http://forum.codejock.com/forum_posts.asp?TID=19884&PID=69009&title=virtual-onvaluechanged-arguments-changed#69009 <![CDATA[Virtual OnValueChanged arguments changed : CodeJock even broke some of their...]]> http://forum.codejock.com/forum_posts.asp?TID=19884&PID=69008&title=virtual-onvaluechanged-arguments-changed#69008 Author: MarkWoodard
Subject: 19884
Posted: 30 September 2012 at 12:23pm

CodeJock even broke some of their own code with this change: CXTPPropertyGridItemSize and CSTPPropertyGridItemPoint no longer work correctly, and who knows how many other property items of theirs?]]> Sun, 30 Sep 2012 12:23:14 +0000 http://forum.codejock.com/forum_posts.asp?TID=19884&PID=69008&title=virtual-onvaluechanged-arguments-changed#69008 <![CDATA[Virtual OnValueChanged arguments changed : Yeah I was about to post about...]]> http://forum.codejock.com/forum_posts.asp?TID=19884&PID=68825&title=virtual-onvaluechanged-arguments-changed#68825 Author: apautrot
Subject: 19884
Posted: 24 August 2012 at 4:53am

Yeah I was about to post about that.

"Thanks, the changes have been reverted for the next release so you can still use your existing code."

And so we will have to re-change all the calls again... you should stick to the change once for all.
]]> Fri, 24 Aug 2012 04:53:43 +0000 http://forum.codejock.com/forum_posts.asp?TID=19884&PID=68825&title=virtual-onvaluechanged-arguments-changed#68825 <![CDATA[Virtual OnValueChanged arguments changed : Agree... ]]> http://forum.codejock.com/forum_posts.asp?TID=19884&PID=68782&title=virtual-onvaluechanged-arguments-changed#68782 Author: cpede
Subject: 19884
Posted: 20 August 2012 at 10:08am

Agree...]]> Mon, 20 Aug 2012 10:08:54 +0000 http://forum.codejock.com/forum_posts.asp?TID=19884&PID=68782&title=virtual-onvaluechanged-arguments-changed#68782 <![CDATA[Virtual OnValueChanged arguments changed : I Just got bitten by this, we...]]> http://forum.codejock.com/forum_posts.asp?TID=19884&PID=68691&title=virtual-onvaluechanged-arguments-changed#68691 Author: adrien
Subject: 19884
Posted: 01 August 2012 at 8:04pm

I Just got bitten by this, we will have to re-release all our products.

These things are not obvious in testing.  You don't expect a property grid item to stop working, it still looks ok.

If you change it back, that's just going to mean we have to re-change all our code back again - we already fixed it up.

So please just leave it.
]]> Wed, 01 Aug 2012 20:04:33 +0000 http://forum.codejock.com/forum_posts.asp?TID=19884&PID=68691&title=virtual-onvaluechanged-arguments-changed#68691 <![CDATA[Virtual OnValueChanged arguments changed : Thanks, the changes have been...]]> http://forum.codejock.com/forum_posts.asp?TID=19884&PID=68477&title=virtual-onvaluechanged-arguments-changed#68477 Author: SuperMario
Subject: 19884
Posted: 21 June 2012 at 3:01pm

Thanks, the changes have been reverted for the next release so you can still use your existing code.

virtual void OnValueChanged(CString strValue);

void CXTPPropertyGridItem::OnValueChanged(CString strValue)
]]> Thu, 21 Jun 2012 15:01:55 +0000 http://forum.codejock.com/forum_posts.asp?TID=19884&PID=68477&title=virtual-onvaluechanged-arguments-changed#68477 <![CDATA[Virtual OnValueChanged arguments changed : Aggg, you just changed the virtual...]]> http://forum.codejock.com/forum_posts.asp?TID=19884&PID=68473&title=virtual-onvaluechanged-arguments-changed#68473 Author: cpede
Subject: 19884
Posted: 20 June 2012 at 10:06am

Aggg, you just changed the virtual method from:

virtual void OnValueChanged(CString strValue);
 
in v15.2.1, to

virtual void OnValueChanged(const CString &strValue);

in v15.3.1, WITHOUT WRITING IT IN THE RELEASE NOTES.
 
This of cause breaks all existing code without any compiler warnings etc.
 
-cpede
]]> Wed, 20 Jun 2012 10:06:40 +0000 http://forum.codejock.com/forum_posts.asp?TID=19884&PID=68473&title=virtual-onvaluechanged-arguments-changed#68473