CXTPPropertyGridItem::Remove causing Crash?

Hi,

I'm working with XTPro version 11.2.1 and we are experiencing a crash when we call the CXTPPropertyGridItem::Remove function.

Has anyone else had this problem?

The code that was giving us the crash is as follows:

CXTPPropertyGridItem* pSelected = m_wndGrid.GetSelectedItem();
if(!pSelected) return;
pSelected->Remove();

We were able to get around the issue using the following code based off of the CXTPPropertyGridItem::Remove() code but without the InternalRelease:

CXTPPropertyGridItem* pSelected = m_wndGrid.GetSelectedItem();
if(!pSelected) return;
CXTPPropertyGridItems* pItems = pSelected->GetParentItem()->GetChilds();
ASSERT(pItems);
int nIndex = pItems ? pItems->Find(pSelected) : -1;

if (nIndex != -1)
{
        pItems->RemoveAt(nIndex);
}

I think it may be the InernalRelase call the is causing the problem, since removing the CXTPPropertyGridItem item from CXTPPropertyGridItems seems to delete it?

Does anyone have any ideas? Is this a bug or am I doing something wrong?

Thanks.

Hi Oleg we are creating the items like so:

CXTPPropertyGridItem* pItem =
            new CXTPPropertyGridItem(strName
            , strValue);

And then adding them to the Grid like so:

pCategory->InsertChildItem(i, pItem);

Where pCategory is a CXTPPropertyGridItem.

As I said in my previous post:

pSelected->Remove();

Used to work fine in previous versions of XtreeToolkit Pro, but now it appears to cause a crash.

Can you confirm that CXTPPropertyGridItem::Remove does not cause a crash?

After removing the item from the CXTPPropertyGridItems array is it safe to call InternalRelease?

pItems->m_arrItems.RemoveAt(nIndex);
InternalRelease();

This problem appears to be affecting more then one of our programs so I am interested in learning if it is a bug or a problem on our side.

Hi,

Thanks wolfgang6, I was going to post that, but I didn't have a chance and thanks Oleg for finding a workaround.

I'm assuming that in future versions this will be fixed?

oleg wrote: Yes, think we will release  some 11.2.2 with this fix. Thnks for point this bug.

No Problem Oleg, any idea when 11.2.2 will be released? We have a release coming up so I'm just trying to decide if I want to use your workaround or if I should hold off for the new version.

It's a great feeling to help the gurus ;-)

 

Solving the problem we discussed above did not solve all the problems in my code. I'm updating from version 10.3.1. Please take a look:

 

class CMyPropGrid : public CXTPPropertyGrid {...}

 

BOOL CMyPropGrid::Create(const RECT& rect, CWnd* pParentWnd, UINT nID, DWORD dwListStyle) {

  CXTPPropertyGrid::Create(rect, pParentWnd, nID, dwListStyle);

  CXTPPropertyGridItem* pgitDummy = CreateItem(_T("dummy"), _T(""));

  CXTPPropertyGridItem* pgitDummyCat = AddCategory(_T("DUMMY-CAT"));

  pgitDummyCat->AddChildItem(pgitDummy);

  //...compute the grid height for x rows using heigth of pigtDummy

  pgitDummy->Remove(); // !

  pgitDummyCat->Remove(); // !

  //...

  ResetContent();

  //...

}

 

With 12.2.1, I have to skip pgitDummy->Remove() or pgitDummyCat->Remove() or both. Otherwise CXTPPropertyGridView::ResetContent() runs into a memory fault at pItem->SetVisible(FALSE); pItem == pguitDummyCat at this time.

 

Regards

Wolfgang

It should look like this:

// Deletes the item.
void CXTPPropertyGridItem::Remove()
{
    if (!m_pGrid)
        return;

    CXTPPropertyGridItems* pItems = GetParentItem() == 0 ? m_pGrid->m_pCategories : GetParentItem()->m_pChilds;
    ASSERT(pItems);
    int nIndex = pItems ? pItems->Find(this) : -1;

        m_pParent = NULL;
        if (m_pGrid) m_pGrid->Refresh();

    if (nIndex != -1)
    {
        pItems->m_arrItems.RemoveAt(nIndex);
        InternalRelease();
    }
}

Hi,

second if (m_pGrid) can be removed.

    Jimmy

It works in my code too, thank you.