Codejock Developer Community : CXTPPropertyGridItem::Remove causing Crash?

CXTPPropertyGridItem::Remove causing Crash? : It works in my code too, thank...

Fri, 16 Nov 2007 01:49:15 +0000

Author: wolfgang6
Subject: 8735
Posted: 16 November 2007 at 1:49am

It works in my code too, thank you.

CXTPPropertyGridItem::Remove causing Crash? : oleg wrote:Here what we changed:...Thanks...

Thu, 15 Nov 2007 14:16:06 +0000

Author: IRMark
Subject: 8735
Posted: 15 November 2007 at 2:16pm

oleg wrote:

Here what we changed:
...

Thanks Oleg, that one worked for us. I guess InternalRelease() has to be the very very (not even in an if statement) line in the function.

Also nice point jimmy.

CXTPPropertyGridItem::Remove causing Crash? : Hi,second if (m_pGrid) can be...

Thu, 15 Nov 2007 09:28:37 +0000

Author: jimmy
Subject: 8735
Posted: 15 November 2007 at 9:28am

Hi,

second if (m_pGrid) can be removed.

Jimmy

CXTPPropertyGridItem::Remove causing Crash? : Here what we changed: void...

Thu, 15 Nov 2007 08:39:50 +0000

Author: Oleg
Subject: 8735
Posted: 15 November 2007 at 8:39am

Here what we changed:

void CXTPPropertyGridItem::Remove()
{
if (!m_pGrid)
return;

CXTPPropertyGridItems* pItems = GetParentItem() == 0 ? m_pGrid->m_pCategories : GetParentItem()->m_pChilds;
ASSERT(pItems);
int nIndex = pItems ? pItems->Find(this) : -1;

if (nIndex == -1)
return;

pItems->m_arrItems.RemoveAt(nIndex);

m_pParent = NULL;

if (m_pGrid) m_pGrid->Refresh();
InternalRelease();
}

CXTPPropertyGridItem::Remove causing Crash? : It should look like this:// Deletes...

Thu, 15 Nov 2007 06:28:12 +0000

Author: wolfgang6
Subject: 8735
Posted: 15 November 2007 at 6:28am

It should look like this:

// Deletes the item.
void CXTPPropertyGridItem::Remove()
{
    if (!m_pGrid)
        return;

    CXTPPropertyGridItems* pItems = GetParentItem() == 0 ? m_pGrid->m_pCategories : GetParentItem()->m_pChilds;
    ASSERT(pItems);
    int nIndex = pItems ? pItems->Find(this) : -1;

        m_pParent = NULL;
        if (m_pGrid) m_pGrid->Refresh();

    if (nIndex != -1)
    {
        pItems->m_arrItems.RemoveAt(nIndex);
        InternalRelease();
    }
}

CXTPPropertyGridItem::Remove causing Crash? : oleg wrote:Hello, There...

Wed, 14 Nov 2007 11:37:04 +0000

Author: IRMark
Subject: 8735
Posted: 14 November 2007 at 11:37am

oleg wrote:

Hello,

There are not much changes for 11.2.2 for now, so I not sure. Think best slution for you is patch our sources and move InternalRelease to the bottom.

Hi,

We have also tried patching the code as follows:

// Deletes the item.
void CXTPPropertyGridItem::Remove()
{
    if (!m_pGrid)
        return;

    CXTPPropertyGridItems* pItems = GetParentItem() == 0 ? m_pGrid->m_pCategories : GetParentItem()->m_pChilds;
    ASSERT(pItems);
    int nIndex = pItems ? pItems->Find(this) : -1;

    if (nIndex != -1)
    {
        m_pParent = NULL;
        if (m_pGrid) m_pGrid->Refresh();
        pItems->m_arrItems.RemoveAt(nIndex);
        InternalRelease();
    }
}

But this does not seem to solve the problem either, and we have continued to experience a crash.

This is a serious issue for us as we have spent a lot of time on it, and are approaching the release of our software.

CXTPPropertyGridItem::Remove causing Crash? : It's a great feeling...

Wed, 14 Nov 2007 07:07:53 +0000

Author: wolfgang6
Subject: 8735
Posted: 14 November 2007 at 7:07am

It's a great feeling to help the gurus ;-)

Solving the problem we discussed above did not solve allthe problems in my code. I'm updating from version 10.3.1. Please take a look:

class CMyPropGrid : public CXTPPropertyGrid {...}

BOOL CMyPropGrid::Create(const RECT& rect, CWnd*pParentWnd, UINT nID, DWORD dwListStyle) {

CXTPPropertyGrid::Create(rect, pParentWnd, nID, dwListStyle);

CXTPPropertyGridItem* pgitDummy = CreateItem(_T("dummy"),_T(""));

CXTPPropertyGridItem* pgitDummyCat =AddCategory(_T("DUMMY-CAT"));

pgitDummyCat->AddChildItem(pgitDummy);

//...compute thegrid height for x rows using heigth of pigtDummy

pgitDummy->Remove(); // !

pgitDummyCat->Remove(); // !

//...

ResetContent();

//...

}

With 12.2.1, I have to skip pgitDummy->Remove()or pgitDummyCat->Remove() or both. Otherwise CXTPPropertyGridView::ResetContent() runsinto a memory fault at pItem->SetVisible(FALSE); pItem == pguitDummyCat atthis time.

Regards

Wolfgang

CXTPPropertyGridItem::Remove causing Crash? : Hello, There are not much changes...

Wed, 14 Nov 2007 00:59:49 +0000

Author: Oleg
Subject: 8735
Posted: 14 November 2007 at 12:59am

Hello,

There are not much changes for 11.2.2 for now, so I not sure. Think best slution for you is patch our sources and move InternalRelease to the bottom.

CXTPPropertyGridItem::Remove causing Crash? : oleg wrote: Yes, think we...

Tue, 13 Nov 2007 13:06:56 +0000

Author: IRMark
Subject: 8735
Posted: 13 November 2007 at 1:06pm

oleg wrote:

Yes, think we will release some 11.2.2 with this fix.

Thnks for point this bug.

No Problem Oleg, any idea when 11.2.2 will be released? We have a release coming up so I'm just trying to decide if I want to use your workaround or if I should hold off for the new version.

CXTPPropertyGridItem::Remove causing Crash? : Hi, Yes, think we will release...

Tue, 13 Nov 2007 13:00:19 +0000

Author: Oleg
Subject: 8735
Posted: 13 November 2007 at 1:00pm

Hi,

Yes, think we will release some 11.2.2 with this fix.

Thnks for point this bug.