Hi All, 

I have found a small bug in handling of skinned menus.

The mnemonic characters did not work with custom menus. 

So e.g. for menu "File" do not work combination ALT+F, S

The key ALT+F will open (popup) menu, but the reaction on pressing e.g. "S" is lost. 

In Version 15.2.1  should be fixed function CXTPSkinPopupMenuState::OnChar(...) in file XTPSkinObjectMenu.cpp. 

There in handling of case MNC_SELECT should be corrected range of valid menu items 

to interval <0,pPopuMenu->GetCount() ).

 

So simple, there should be changed wrong condition 

    from : 

         if (nItem < 0 || nItem < pPopupMenu->GetCount())

    to :   

         if (nItem < 0 || nItem >= pPopupMenu->GetCount())

I did not checked if recent version 15.3.1 has the same bug or not. 

With best regards,

Ivan

 

Even in TKP 16.2.3 this isn't fixed yet. So I guess it was lost in the stack of other issues

 

I've tested the solution and it does fix the problem for me too.

 

It's a small change and even a simple guy can see what's wrong in the original code

 

It is appreciated if this change can find its way to the next release, since I need to change this by hand everytime a release comes out

 

Best regards,

 

Insad

 

http://forum.codejock.com/forum_posts.asp?TID=21767&PID=71487#71487" rel="nofollow - http://forum.codejock.com/forum_posts.asp?TID=21767&PID=71487#71487