BUG in Handling of mnemonic chars in menu

Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic

   Hi All, 
I have found a small bug in handling of skinned menus.

The mnemonic characters did not work with custom menus. 
So e.g. for menu "File" do not work combination ALT+F, S
The key ALT+F will open (popup) menu, but the reaction on pressing e.g. "S" is lost. 

In Version 15.2.1  should be fixed function CXTPSkinPopupMenuState::OnChar(...) in file XTPSkinObjectMenu.cpp. 

There in handling of case MNC_SELECT should be corrected range of valid menu items 
to interval <0,pPopuMenu->GetCount() ).

So simple, there should be changed wrong condition 
    from : 
         if (nItem < 0 || nItem < pPopupMenu->GetCount())
    to :   
         if (nItem < 0 || nItem >= pPopupMenu->GetCount())

I did not checked if recent version 15.3.1 has the same bug or not. 

With best regards,
Ivan

Author	Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic
ivpa Members Profile Send Private Message Find Members Posts Add to Buddy List Newbie Joined: 28 February 2012 Status: Offline Points: 13	Post Options Post Reply Quote ivpa Report Post Thanks(1) Quote Reply Topic: BUG in Handling of mnemonic chars in menu Posted: 23 July 2012 at 11:12am
	Hi All, I have found a small bug in handling of skinned menus. The mnemonic characters did not work with custom menus. So e.g. for menu "File" do not work combination ALT+F, S The key ALT+F will open (popup) menu, but the reaction on pressing e.g. "S" is lost. In Version 15.2.1 should be fixed function CXTPSkinPopupMenuState::OnChar(...) in file XTPSkinObjectMenu.cpp. There in handling of case MNC_SELECT should be corrected range of valid menu items to interval <0,pPopuMenu->GetCount() ). So simple, there should be changed wrong condition from : if (nItem < 0 \|\| nItem < pPopupMenu->GetCount()) to : if (nItem < 0 \|\| nItem >= pPopupMenu->GetCount()) I did not checked if recent version 15.3.1 has the same bug or not. With best regards, Ivan

Insad Members Profile Send Private Message Find Members Posts Add to Buddy List Groupie Joined: 28 October 2004 Location: The Netherlands Status: Offline Points: 55	Post Options Post Reply Quote Insad Report Post Thanks(0) Quote Reply Posted: 30 July 2013 at 10:40am
	Sorry for bumping this post, but might it be possible that someone at CodeJock puts this on a todo list? Even in TKP 16.2.3 this isn't fixed yet. So I guess it was lost in the stack of other issues I've tested the solution and it does fix the problem for me too. It's a small change and even a simple guy can see what's wrong in the original code It is appreciated if this change can find its way to the next release, since I need to change this by hand everytime a release comes out Best regards, Insad
	Products in use: XTP version 13.4.2/15.3.1/16.4.0/17.3.0 Platforms: Win2003(R2)/Win2008(R2)/Win7/Win2011/Win8(.1)/Win2012(R2)/Win10 (x86/x64) Langs: VC++ (MFC) 6/2005/2008/2013/2015/2017

ivpa Members Profile Send Private Message Find Members Posts Add to Buddy List Newbie Joined: 28 February 2012 Status: Offline Points: 13	Post Options Post Reply Quote ivpa Report Post Thanks(0) Quote Reply Posted: 12 August 2013 at 1:45pm
	Seems that this has double here : http://forum.codejock.com/forum_posts.asp?TID=21767&PID=71487#71487