CPropertyGridItemBool bug

Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic

   What happens if Bool item has a child or children and you try to check/uncheck the check box (SetCheckBoxStyle(TRUE) has been called for the item)? Item is expanded and check box is not selected! Here's why:
BOOL CXTPPropertyGridItemBool::OnKeyDown (UINT nChar)
{
 if (m_bCheckBoxStyle && !GetReadOnly() && (nChar == VK_SPACE))
 {
  OnLButtonDblClk();
  return TRUE;
 }
 return FALSE;
}
BOOL CXTPPropertyGridItemBool::OnLButtonDown(UINT nFlags, CPoint point)
{
 if (!CXTPPropertyGridItem::OnLButtonDown(nFlags, point))
  return FALSE;
 if (m_bCheckBoxStyle)
 {
  CRect rc = GetValueRect();
  rc.right = rc.left + 15;
  if (rc.PtInRect(point) && !GetReadOnly())
  {
   OnLButtonDblClk();
  }
 }
 return TRUE;
}

OnLButtonDblClk() is called but value is not changed!
Fix? Thanks.

Author	Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic
tmolander Members Profile Send Private Message Find Members Posts Add to Buddy List Newbie Joined: 11 April 2006 Location: Finland Status: Offline Points: 3	Post Options Post Reply Quote tmolander Report Post Thanks(0) Quote Reply Topic: CPropertyGridItemBool bug Posted: 05 May 2006 at 4:37am
	What happens if Bool item has a child or children and you try to check/uncheck the check box (SetCheckBoxStyle(TRUE) has been called for the item)? Item is expanded and check box is not selected! Here's why: BOOL CXTPPropertyGridItemBool::OnKeyDown (UINT nChar) { if (m_bCheckBoxStyle && !GetReadOnly() && (nChar == VK_SPACE)) { OnLButtonDblClk(); return TRUE; } return FALSE; } BOOL CXTPPropertyGridItemBool::OnLButtonDown(UINT nFlags, CPoint point) { if (!CXTPPropertyGridItem::OnLButtonDown(nFlags, point)) return FALSE; if (m_bCheckBoxStyle) { CRect rc = GetValueRect(); rc.right = rc.left + 15; if (rc.PtInRect(point) && !GetReadOnly()) { OnLButtonDblClk(); } } return TRUE; } OnLButtonDblClk() is called but value is not changed! Fix? Thanks.

Oleg Members Profile Send Private Message Find Members Posts Add to Buddy List Senior Member Joined: 21 May 2003 Location: United States Status: Offline Points: 11234	Post Options Post Reply Quote Oleg Report Post Thanks(0) Quote Reply Posted: 05 May 2006 at 9:06am
	Hello, It was already fixed in 10.1 release. Was added parameters to OnLButtonDblClk: BOOL CXTPPropertyGridItemBool::OnKeyDown (UINT nChar) { if (m_bCheckBoxStyle && !GetReadOnly() && (nChar == VK_SPACE)) { CRect rc = GetValueRect(); OnLButtonDblClk(0, rc.CenterPoint()); return TRUE; } return FALSE; } void CXTPPropertyGridItemBool::OnLButtonDblClk(UINT nFlags, CPoint point) { if (m_bCheckBoxStyle && PtInValueRect(point) && !GetReadOnly()) { OnSelect(); SelectNextConstraint(); } else { CXTPPropertyGridItem::OnLButtonDblClk(nFlags, point); } } etc.
	Oleg, Support Team CODEJOCK SOFTWARE SOLUTIONS