CXTColorPopup now calling DestroyWindow

Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic

You changed this code from v1211:

void CXTColorPopup::EndSelection(int nCurSel)

{
CXTPMouseMonitor::SetupHook(NULL);

OnEndSelection(nCurSel, m_callerParam);

PostMessage(WM_CLOSE);

}

to this code in v1300:

void CXTColorPopup::EndSelection(int nCurSel)
{
CXTPMouseMonitor::SetupHook(NULL);
OnEndSelection(nCurSel, m_callerParam);
DestroyWindow();
}

But the direct call to DestroyWindow makes my Color Popup crash!

A quick debug shows that the EndSelection is called from both CXTColorPopup::OnKillFocus and
from CXTColorSelectorCtrl::OnLButtonUp, making the second call fail.

-cpede

Author	Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic
cpede Members Profile Send Private Message Find Members Posts Add to Buddy List Senior Member Joined: 13 August 2004 Location: Denmark Status: Offline Points: 668	Post Options Post Reply Quote cpede Report Post Thanks(0) Quote Reply Topic: CXTColorPopup now calling DestroyWindow Posted: 24 February 2009 at 3:45am
	You changed this code from v1211: void CXTColorPopup::EndSelection(int nCurSel) { CXTPMouseMonitor::SetupHook(NULL); OnEndSelection(nCurSel, m_callerParam); PostMessage(WM_CLOSE); } to this code in v1300: void CXTColorPopup::EndSelection(int nCurSel) { CXTPMouseMonitor::SetupHook(NULL); OnEndSelection(nCurSel, m_callerParam); DestroyWindow(); } But the direct call to DestroyWindow makes my Color Popup crash! A quick debug shows that the EndSelection is called from both CXTColorPopup::OnKillFocus and from CXTColorSelectorCtrl::OnLButtonUp, making the second call fail. -cpede

cpede Members Profile Send Private Message Find Members Posts Add to Buddy List Senior Member Joined: 13 August 2004 Location: Denmark Status: Offline Points: 668	Post Options Post Reply Quote cpede Report Post Thanks(0) Quote Reply Posted: 03 August 2009 at 3:54am
	This is still a problem in v1310. -cpede
	Product: Xtreme ToolkitPro (24.0.0) Platform: Windows 10 (x64) Language: Visual Studio 2017 (C++)

Oleg Members Profile Send Private Message Find Members Posts Add to Buddy List Admin Group Joined: 21 May 2003 Location: United States Status: Offline Points: 11234	Post Options Post Reply Quote Oleg Report Post Thanks(0) Quote Reply Posted: 06 August 2009 at 12:48am
	Hello, We added flag now to prevent second call: void CXTColorPopup::EndSelection(int nCurSel) { m_bEndSelection = TRUE; CXTPMouseMonitor::SetupHook(NULL); OnEndSelection(nCurSel, m_callerParam); DestroyWindow(); } void CXTColorPopup::OnKillFocus(CWnd* pNewWnd) { CWnd::OnKillFocus(pNewWnd); if (!m_pColorDlg && !m_bEndSelection) { EndSelection(-1); } }
	Oleg, Support Team CODEJOCK SOFTWARE SOLUTIONS