Toggling frame theme is buggy

Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic

XTP 13.1, RibbonSample.

When toggling the frame theme, the window is restored. This is very annoying, so I removed the ShowWindow-call below. However, if removed, the behavior is really weird (buggy). I have found that Vista GUI changes the logic somehow. Can you please test this function a little bit and comment?

void CMainFrame::OnFrameTheme()

{
ShowWindow(SW_NORMAL); // Why?! Removing it solves one thing, but screws another...
CXTPRibbonBar* pRibbonBar = (CXTPRibbonBar*)GetCommandBars()->GetAt(0);
CXTPWindowRect rc(this);

rc.top += (pRibbonBar->IsFrameThemeEnabled() ? -1 : +1) * GetSystemMetrics(SM_CYCAPTION);
MoveWindow(rc);

pRibbonBar->EnableFrameTheme(!pRibbonBar->IsFrameThemeEnabled());
}

Author	Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic
znakeeye Members Profile Send Private Message Find Members Posts Add to Buddy List Senior Member Joined: 26 July 2006 Status: Offline Points: 1672	Post Options Post Reply Quote znakeeye Report Post Thanks(0) Quote Reply Topic: Toggling frame theme is buggy Posted: 22 July 2009 at 6:21pm
	XTP 13.1, RibbonSample. When toggling the frame theme, the window is restored. This is very annoying, so I removed the ShowWindow-call below. However, if removed, the behavior is really weird (buggy). I have found that Vista GUI changes the logic somehow. Can you please test this function a little bit and comment? void CMainFrame::OnFrameTheme() { ShowWindow(SW_NORMAL); // Why?! Removing it solves one thing, but screws another... CXTPRibbonBar* pRibbonBar = (CXTPRibbonBar)GetCommandBars()->GetAt(0); CXTPWindowRect rc(this); rc.top += (pRibbonBar->IsFrameThemeEnabled() ? -1 : +1) GetSystemMetrics(SM_CYCAPTION); MoveWindow(rc); pRibbonBar->EnableFrameTheme(!pRibbonBar->IsFrameThemeEnabled()); }
	PokerMemento - http://www.pokermemento.com/

Oleg Members Profile Send Private Message Find Members Posts Add to Buddy List Admin Group Joined: 21 May 2003 Location: United States Status: Offline Points: 11234	Post Options Post Reply Quote Oleg Report Post Thanks(0) Quote Reply Posted: 24 July 2009 at 4:15am
	Hi, So "screws another" problem is restoring that you don't like ? Don't think your customers will switch it each day. Guess they can live with restoring frame once in life :) anyway you can check WS_MAXIMIZE style and Maximize it back after you switch it.
	Oleg, Support Team CODEJOCK SOFTWARE SOLUTIONS

znakeeye Members Profile Send Private Message Find Members Posts Add to Buddy List Senior Member Joined: 26 July 2006 Status: Offline Points: 1672	Post Options Post Reply Quote znakeeye Report Post Thanks(0) Quote Reply Posted: 25 July 2009 at 2:43am
	Well, if I started my application in a maximized state I do not want to restore it just like that. And if I remove that ShowWindow-call, the frame theme gets screwed in Vista Aero (until I restart my application, of course). But sure, I can live with a "restoration" once every 313 days :P
	PokerMemento - http://www.pokermemento.com/