A few more specific suggestions...

 

1. I suggest the TDX (Task Dialog XML) file extension for such files when they become a Valid XML.

 

2. A designer, called "TDX Designer" to create such files and edit existing ones.

 

3. Not sure if you do not have yet, but it MUST support dynamic context, i.e. specifying some text anchors within XML text data instead of the actual text, and then fire events within the library to get such text on-the-fly.

 

Regards,

Vitaly

 

 

you can download XML editor for dialog:

http://shellrevealed.com/files/folders/code/tags/TDPad/default.aspx - http://shellrevealed.com/files/folders/code/tags/TDPad/default.aspx

 

 

 

I have looked at it, and I saw the same problem - Not Valid XML. And because it is not valid, CodeJock's variation of it differs from the one that TDPad authors suggested:

 

In their TDPad Help they mention that attributes PHeader, TDHeader and IdRange are required for tag Dialogs, while you do not use them in your CodeJock's examples at all.

 

This is a typical kind of mess that happens when using a Non-Valid XML.

 

One must develop a proper format and proper XML schema for such documents, because otherwise a question arises: Why any company should invest money and time in designing UI using some unknown-format file, which can change tomorrow and then i'm stuck with a load of unusable XML files...

 

This is serious... I would urge to attend this matter very soon...

 

This is not something a Microsoft partner would let get through. Microsoft doesn't produce invalid XML these days, and neither should you.

 

 

 

1. Default resource file

2. Custom resource file

3. External File

 

Currently, it is very unflexible...

 

Hi,

I see your point with resources. We added

 

 BOOL CreateFromResource(UINT nIDResource, LPCTSTR lpszDialog);
 BOOL CreateFromResource(HINSTANCE hInstance, UINT nIDResource, LPCTSTR lpszDialog);

BOOL CreateFromResourceParam(HINSTANCE hInstance, UINT nIDResource, LPCTSTR lpszDialog, LPCTSTR const* rglpsz, int nString);

 

methods. You can patch your sources now:

 

BOOL CXTPTaskDialog::CreateFromResource(UINT nIDResource, LPCTSTR lpszDialog)
{
 return CreateFromResource(AfxGetInstanceHandle(), nIDResource, lpszDialog);
}

etc

 

<?xml version="1.0" encoding="utf-8"?>
<xs:schema attributeFormDefault="unqualified" elementFormDefault="qualified" xmlns:xs=" http://www.w3.org/2001/XMLSchema - http://www.w3.org/2001/XMLSchema ">
  <xs:element name="Dialogs">
    <xs:complexType>
      <xs:sequence>
        <xs:element maxOccurs="unbounded" name="Dialog">
          <xs:complexType>
            <xs:sequence>
              <xs:choice maxOccurs="unbounded">
                <xs:element name="WindowTitle" type="xs:string" maxOccurs="1" />
                <xs:element name="MainInstruction" maxOccurs="1">
                  <xs:complexType>
                    <xs:simpleContent>
                      <xs:extension base="xs:string">
                        <xs:attribute name="Image" type="xs:string" use="optional" />
                      </xs:extension>
                    </xs:simpleContent>
                  </xs:complexType>
                </xs:element>
                <xs:element name="Verification" maxOccurs="1">
                  <xs:complexType>
                    <xs:simpleContent>
                      <xs:extension base="xs:string">
                        <xs:attribute name="Checked" type="xs:boolean" use="optional" default="false" />
                      </xs:extension>
                    </xs:simpleContent>
                  </xs:complexType>
                </xs:element>
                <xs:element name="Content" type="xs:string" maxOccurs="1" />
                <xs:element name="ExpandedInformation" maxOccurs="1">
                  <xs:complexType>
                    <xs:simpleContent>
                      <xs:extension base="xs:string">
                        <xs:attribute name="Footer" type="xs:boolean" use="optional" default="false" />
                      </xs:extension>
                    </xs:simpleContent>
                  </xs:complexType>
                </xs:element>
                <xs:element name="ExpandedText" type="xs:string" maxOccurs="1" />
                <xs:element name="CollapsedText" type="xs:string" maxOccurs="1" />
                <xs:element name="RadioButtons" maxOccurs="1">
                  <xs:complexType>
                    <xs:sequence>
                      <xs:element maxOccurs="unbounded" name="RadioButton">
                        <xs:complexType>
                          <xs:simpleContent>
                            <xs:extension base="xs:string">
                              <xs:attribute name="ID" type="xs:long" use="required" />
                            </xs:extension>
                          </xs:simpleContent>
                        </xs:complexType>
                      </xs:element>
                    </xs:sequence>
                    <xs:attribute name="Default" type="xs:long" use="required" />
                  </xs:complexType>
                </xs:element>
                <xs:element name="Buttons" maxOccurs="1">
                  <xs:complexType>
                    <xs:sequence>
                      <xs:element minOccurs="0" name="Close" />
                      <xs:element minOccurs="0" name="Yes" />
                      <xs:element minOccurs="0" name="No" />
                      <xs:element minOccurs="0" name="Ok" />
                      <xs:element minOccurs="0" name="Retry" />
                      <xs:element minOccurs="0" name="Cancel" />
                      <xs:element minOccurs="0" maxOccurs="unbounded" name="CommandLink">
                        <xs:complexType>
                          <xs:sequence>
                            <xs:element name="Text" type="xs:string" />
                            <xs:element name="Explanation" type="xs:string" use="optional" />
                          </xs:sequence>
                          <xs:attribute name="Shield" type="xs:boolean" use="optional" />
                          <xs:attribute name="ID" type="xs:long" use="required" />
                        </xs:complexType>
                      </xs:element>
                      <xs:element minOccurs="0" maxOccurs="unbounded" name="Button">
                        <xs:complexType>
                          <xs:simpleContent>
                            <xs:extension base="xs:string">
                              <xs:attribute name="ID" type="xs:long" use="required" />
                              <xs:attribute name="Shield" type="xs:boolean" use="optional" />
                            </xs:extension>
                          </xs:simpleContent>
                        </xs:complexType>
                      </xs:element>
                    </xs:sequence>
                    <xs:attribute name="Default" type="xs:long" use="optional" />
                  </xs:complexType>
                </xs:element>
                <xs:element name="Footer" maxOccurs="1">
                  <xs:complexType>
                    <xs:simpleContent>
                      <xs:extension base="xs:string">
                        <xs:attribute name="Image" type="xs:string" use="optional" />
                      </xs:extension>
                    </xs:simpleContent>
                  </xs:complexType>
                </xs:element>
              </xs:choice>
            </xs:sequence>
            <xs:attribute name="Name" type="xs:string" use="required" />
            <xs:attribute name="EnableHyperlinks" type="xs:boolean" use="optional" />
            <xs:attribute name="AllowCancel" type="xs:boolean" use="optional" />
            <xs:attribute name="ProgressBar" type="xs:boolean" use="optional" />
            <xs:attribute name="Width" type="xs:long" use="optional" />
            <xs:attribute name="RelativeToWindow" type="xs:boolean" use="optional" />
            <xs:attribute name="RTLLayout" type="xs:boolean" use="optional" />
            <xs:attribute name="NoDefaultRadioButton" type="xs:boolean" use="optional" />
            <xs:attribute name="MessageBoxStyle" type="xs:boolean" use="optional" />
          </xs:complexType>
        </xs:element>
      </xs:sequence>
    </xs:complexType>
  </xs:element>
</xs:schema>

 

There first was a problem opening the schema, because of the following line:

 

 

ok, thanks, waiting finished schema from you.

 

1. Attribute MessageBoxStyle was introduced by CodeJock for tag Dialog. It doesn’t seem beneficial to the concept, because it relates exclusively to CodeJock’s theme support. When making this a standard and working out a schema, doesn’t seem justified to be present in the schema. It is probably best to be just a property within class CXTPTaskDialog, and not to be read from the XML at all. What do you think?

 

 

2. For tag Dialog you are missing two attributes that were suggested in the original TDPad specification: NoCommandLinkGlyph and UseTDCallback. I am tempted to include these, while leaving this up to you whether or not you are going to implement them. Again, what do you think about it?

 

So, i'm leaving Dialogs without any attribute, which corresponds to the codejock's implementation...

 

 

 

yes NoCommandLinkGlyph is used now, please add it. Don't see what UseTDCallback can do, because CXTPTaskDialog always use callbacks.

 

 

Regarding your post:

BOOL CreateFromResource(UINT nIDResource, LPCTSTR lpszDialog);  BOOL CreateFromResource(HINSTANCE hInstance, UINT nIDResource, LPCTSTR lpszDialog); BOOL CreateFromResourceParam(HINSTANCE hInstance, UINT nIDResource, LPCTSTR lpszDialog, LPCTSTR const* rglpsz, int nString);   methods. You can patch your sources now:   BOOL CXTPTaskDialog::CreateFromResource(UINT nIDResource, LPCTSTR lpszDialog) {  return CreateFromResource(AfxGetInstanceHandle(), nIDResource, lpszDialog); } etc

 

I don't understand the meaning of the last method. It's supposed to be something like BOOL CreateFromFile(LPCTSTR lpsFilePath, LPCTSTR  lpszDialog); to load from a file...

 

 

As my company was approaching a new software release, i found out that thouhg i use an embedded XML for Task Dialogs, our translation tools (Visual Localize) won't be able to automate translation for such. Now we are forced to use an external XML file for that. Otherwise, i'll have to dumb all the nitty-gritties of TD, which i'd hate to do, we are quite fixed on it now :)

 

Could you, please provide implementation for method CreateFromFile as soon as possible?

 

Thank you!

 

 

BOOL CXTPTaskDialogEx::CreateFromFile(LPCTSTR strFilePath, LPCTSTR lpszDialog) { USES_CONVERSION; CXTPPropExchangeXMLNode px(TRUE, NULL, _T("Dialogs")); if (!px.LoadFromFile(strFilePath)) return FALSE; if (!px.OnBeforeExchange()) return FALSE; px.SetCompactMode(TRUE); CString strDialogSection; strDialogSection.Format(_T("Dialog[@Name='%s']"), lpszDialog); if (!px.IsSectionExists(strDialogSection)) return FALSE;   CXTPPropExchangeSection pxDialog(px.GetSection(strDialogSection)); if (!pxDialog->OnBeforeExchange()) return FALSE; EnableHyperlinks(GetPropExchangeFlag(&pxDialog, _T("EnableHyperlinks"))); EnableCancellation(GetPropExchangeFlag(&pxDialog, _T("AllowCancel"))); ShowProgressBar(GetPropExchangeFlag(&pxDialog, _T("ProgressBar")), FALSE); SetWidth(GetPropExchangeInt(&pxDialog, _T("Width")), TRUE); EnableRelativePosition(GetPropExchangeFlag(&pxDialog, _T("RelativeToWindow"))); EnableRtlLayout(GetPropExchangeFlag(&pxDialog, _T("RTLLayout"))); NoDefaultRadioButton(GetPropExchangeFlag(&pxDialog, _T("NoDefaultRadioButton"))); SetWindowTitle(GetPropExchangeString(&pxDialog, _T("WindowTitle"))); SetMainInstruction(GetPropExchangeString(&pxDialog, _T("MainInstruction"))); SetContent(GetPropExchangeString(&pxDialog, _T("Content"))); SetFooter(GetPropExchangeString(&pxDialog, _T("Footer"))); SetMainIcon(GetPropExchangeIcon(&pxDialog, _T("MainInstruction"))); SetFooterIcon(GetPropExchangeIcon(&pxDialog, _T("Footer"))); CXTPPropExchangeSection pxButtons(pxDialog->GetSection(_T("Buttons"))); CXTPPropExchangeEnumeratorPtr enumButton(pxButtons->GetEnumerator(NULL)); POSITION pos = enumButton->GetPosition(0); while (pos) { CXTPPropExchangeSection secButton(enumButton->GetNext(pos)); CString strSection = ((CXTPPropExchangeXMLNode*)&secButton)->GetSectionName(); int nID = GetPropExchangeInt(&secButton, _T("ID")); if (strSection.CompareNoCase(_T("Button")) == 0 && (nID != 0)) { AddButton(GetPropExchangeString(&secButton, NULL), nID); } else if (strSection.CompareNoCase(_T("CommandLink")) == 0 && (nID != 0)) { CString strText = GetPropExchangeString(&secButton, _T("Text")); CString strExplanation = GetPropExchangeString(&secButton, _T("Explanation")); if (!strExplanation.IsEmpty()) strText += _T("\n") + strExplanation; AddButton(strText, nID); EnableCommandLinks(TRUE, !GetPropExchangeFlag(&pxDialog, _T("NoCommandLinkGlyph"))); } else if (strSection.CompareNoCase(_T("Ok")) == 0) { m_config.dwCommonButtons |= TDCBF_OK_BUTTON; } else if (strSection.CompareNoCase(_T("Yes")) == 0) { m_config.dwCommonButtons |= TDCBF_YES_BUTTON; } else if (strSection.CompareNoCase(_T("No")) == 0) { m_config.dwCommonButtons |= TDCBF_NO_BUTTON; } else if (strSection.CompareNoCase(_T("Cancel")) == 0) { m_config.dwCommonButtons |= TDCBF_CANCEL_BUTTON; } else if (strSection.CompareNoCase(_T("Retry")) == 0) { m_config.dwCommonButtons |= TDCBF_RETRY_BUTTON; } else if (strSection.CompareNoCase(_T("Close")) == 0) { m_config.dwCommonButtons |= TDCBF_CLOSE_BUTTON; } } SetDefaultButton(GetPropExchangeInt(&pxButtons, _T("Default")));   CXTPPropExchangeSection pxRadioButtons(pxDialog->GetSection(_T("RadioButtons"))); CXTPPropExchangeEnumeratorPtr enumRadioButton(pxRadioButtons->GetEnumerator(_T("RadioButton"))); pos = enumRadioButton->GetPosition(0); while (pos) { CXTPPropExchangeSection secButton(enumRadioButton->GetNext(pos)); int nID = GetPropExchangeInt(&secButton, _T("ID")); if (nID != 0) { AddRadioButton(GetPropExchangeString(&secButton, NULL), nID); } } SetDefaultRadioButton(GetPropExchangeInt(&pxRadioButtons, _T("Default"))); if (((CXTPPropExchangeXMLNode*)&pxDialog)->IsSectionExists(_T("ExpandedInformation"))) { CXTPPropExchangeSection pxExpandedInformation(pxDialog->GetSection(_T("ExpandedInformation"))); SetExpandedInformation(GetPropExchangeString(&pxExpandedInformation, NULL)); ExpandFooterArea(GetPropExchangeFlag(&pxExpandedInformation, _T("Footer"))); ExpandedByDefault(GetPropExchangeFlag(&pxExpandedInformation, _T("Expanded"))); SetExpandedControlText(GetPropExchangeString(&pxDialog, _T("ExpandedText"))); SetCollapsedControlText(GetPropExchangeString(&pxDialog, _T("CollapsedText"))); } if (((CXTPPropExchangeXMLNode*)&pxDialog)->IsSectionExists(_T("Verification"))) { CXTPPropExchangeSection pxVerification(pxDialog->GetSection(_T("Verification"))); SetVerificationText(GetPropExchangeString(&pxVerification, NULL)); SetVerifyCheckState(GetPropExchangeFlag(&pxVerification, _T("Checked"))); } return TRUE; }

 

 

As I was implementing all kinds of Task Dialogs, I found one bug in the schema: For tag Buttons, attribute Default must be of type string, not long, because it also accepts standard button names, like Ok, etc...

 

I have fixed it and uploaded to http://www.neatcpp.com/schema/TDSchema.xsd - http://www.neatcpp.com/schema/TDSchema.xsd

 

When you upload it onto your website, do not forget to change neatcpp domain in the header into codejock, and please let me know here when it's done!

 

Sorry for that, but everything needs testing, as you know...

 

And now that i see all my TDX files validate fine -  "me feelin happy" :)))

 

 

Hi,

 

Think long is ok. anyway string will not be parsed in our code - For OK use Id - 1, foc cancel 2 etc.    (IDOK, IDCANCEL...);

 

Will you implement it? The schema to allow that is already there ;)

 

 

 

1. USES_CONVERSION in the beginning is unnecessary there for this method;

 

2. Regarding method names like there in the method's implementation: IsNodeExists() - this is not a good english ;) Should be one of these:

 

bool IsNodePresent()

or

bool NodeExists();

or

bool HasNode();

 

P.S. When all changes for TD support are finished, I wouldn't mind getting the header+ source for testing them ;)

 

 

Hi,

 

For 11.1.2 we moved all common code to another method.

 

It's just so disappointing...

 

BOOL CreateFromResourceParam(CXTPPropExchangeXMLNode* pPX)

 

so you can load using 3 lines of code:

 

CXTPPropExchangeXMLNode px(TRUE, NULL, _T("Dialogs"));

px.LoadFromFile(strFilePath);

 

 CXTPPropExchangeXMLNode px(TRUE, NULL, _T("Dialogs/Dialog[@Name='Dialog002']")); 
 px.LoadFromFile(_T("C:\\Dialogs.xml")); 
 td.CreateFromResourceParam(&px,  0, 0);
 td.DoModal();

 

Hello,

 

Yes, its right code.