The hook function should check wheter the window is skinned or not.

 

Hello,

 

How do you see it? GetSysColor is global function, how skinmanager can determine what window you want to draw?

 

As solution remove xtpSkinApplyColors from ApplyOptions:

 

XTPSkinManager()->SetApplyOptions(xtpSkinApplyMetrics | xtpSkinApplyFrame);

Here is a screenshot of the sheet with skinning disabled. The Grid calls GetSysColor to get the color for the fixed cells. It's the same with the list control on the left.

 

If I remove the xtpSkinApplyColors flag the list control is drawn correctly, but GetSysColor still return the wrong color.

 

 

 

 

I've also noticed several other bugs with the SkinFramework.

 

The above code causes an assertion in CXTPSkinManagerApiHook::OnHookLoadLibraryA because GetInstance()->GetHookedFunction(xtpSkinApiLoadLibraryA); returns NULL the first time OnHookLoadLibrary is beeing called after disabling skinning / settings apply options.

 

I'm using the popular MFCGridCtrl and if skinning is applied and then a scrollbar arrow pressed the grid only scrolls once but doesn't keep scrolling until the button is released. So you've to click/release, click/release to scroll through the grid.

 

If I disable skinning with XTPSkinManager()->SetAutoApplyNewWindows (FALSE); before showing the sheet and then press the arrow button the grid keeps scrolling but the scrollbar doesn't move.

 

If I don't load a skin everything works correctly, you press an arrow button and the grid start and keeps scrolling whilst the scrollbar moves up or down.

 

 

 

easy to fix MFCGridCtrl  than disable this  window for SkinFramework :)

 

in void CGridCtrl::OnTimer(UINT nIDEvent)