If you override GetGroupCaption (e.g. to return “2003” for all dates in the year 2003 for a date) this will cause the sorting to be incorrect when you group by more than one column. (where the column with the overridden GetGroupCaption is the primary group).

 this is because the last line of the function:

CXTPReportRecordItem::CompareGroupCaption

is:

return Compare(pColumn, pItem);

 
This goes in and compares the actual data values, ignoring the overridden caption text.

 The fix is to override CompareGroupCaption, and write:

return GetGroupCaption(pColumn).Collate( pItem->GetGroupCaption(pColumn) );

 
This compare the captions (from the overridden GetGroupCaption), rather than the actual data values.

I would suggest that the last line of CXTPReportRecordItem::CompareGroupCaption

be changed from:

return Compare(pColumn, pItem);

to

return GetGroupCaption(pColumn).Collate( pItem->GetGroupCaption(pColumn)

Hopefully, what I’m suggesting is correct - can someone from Codejock please comment on this.

Thanks

Warren

...or failing that, there should be a HUGE warning comment in the functions telling you that you MUST override CompareGroupCaption if you override GetGroupCaption.