Report Control - [SOLVED]Possible exception after RemoveRecordEx

Print Page | Close Window

[SOLVED]Possible exception after RemoveRecordEx

Printed From: Codejock Forums
Category: Codejock Products
Forum Name: Report Control
Forum Description: Topics Related to Codejock Report Control
URL: http://forum.codejock.com/forum_posts.asp?TID=24531
Printed Date: 02 April 2025 at 10:44pm
Software Version: Web Wiz Forums 12.04 - http://www.webwizforums.com

Topic: [SOLVED]Possible exception after RemoveRecordEx

Posted By: DiZSl
Subject: [SOLVED]Possible exception after RemoveRecordEx
Date Posted: 29 November 2024 at 1:40am

After calling RemoveRecordEx, it is essential to call UpdateWindows for the ReportControl. If this is not done and a user quickly clicks on the deleted record before the window is redrawn (updated), the function HitTest in CXTPReportControl::OnButton will return the deleted CXTPReportRow from the m_pScreenRows array, which is only updated during redrawing. However, the redraw has not yet occurred only invalidating, resulting in m_pScreenRows being out of sync with the main tree.

Additionally, when calling CXTPReportControl::OnButton, this removed CXTPReportRow will be passed to _SetSelectedRow, which will cause an index for a non-existent record to appear in the m_pSelectedRows array. As a result, m_pSelectedRows.GetCount will return 1, while m_pSelectedRows.GetAt(0) will return nullptr.

My solution (remove row from m_pScreenRows):
void CXTPReportRows::RemoveAt(int nIndex)
{
    auto row = m_arrRows.GetAt(nIndex);
    if (row != nullptr)
    {
        auto rows = GetScreenRows();
        if (rows != nullptr)
        {
            auto size = rows->GetCount();
            for (int i = 0; i < size; i++)
            {
                if (rows->GetAt(i) == row)
                {
                    row->InternalRelease();
                    rows->RemoveAt(i);
                    break;
                }
            }
        }

        row->InternalRelease();
    }
    m_arrRows.RemoveAt(nIndex);
}

Replies:

Posted By: agontarenko
Date Posted: 17 December 2024 at 4:47am

Hello,

Thanks for you solution.
How I can to reproduce this bug with our sample?

Regards,
Artem Gonarenko

Posted By: DiZSl
Date Posted: 20 December 2024 at 3:22am

uploads/9437/ReportDialog.zip" rel="nofollow - uploads/9437/ReportDialog.zip

I've modified your example by adding a "Button1" button. It deletes the last record and emulates clicking on that deleted record. After that GetCount method returns 1.

Posted By: agontarenko
Date Posted: 20 December 2024 at 8:14am

Hello,

I've change function with next code

void CXTPGridRows::RemoveAt(int nIndex)
{
    CXTPGridScreenRows* pScreenRows = GetScreenRows();
    if (pScreenRows)
    {
        for (int i = 0; i < pScreenRows->GetCount(); i++)
        {
            if (pScreenRows->GetAt(i) == m_arrRows.GetAt(nIndex))
            {
                pScreenRows->GetAt(i)->InternalRelease();
                pScreenRows->RemoveAt(i);
                break;
            }
        }
    }

    m_arrRows.GetAt(nIndex)->InternalRelease();
    m_arrRows.RemoveAt(nIndex);
}

Note in last versions CXTPReport was renamed to CXTPGrid.

The fix will be available in the next beta or final release.

Regards,

Artem Gontarenko