Toolkit Pro - CXTPImageManagerIconHandle copy constructor

Print Page | Close Window

CXTPImageManagerIconHandle copy constructor

Printed From: Codejock Forums
Category: Codejock Products
Forum Name: Toolkit Pro
Forum Description: Topics Related to Codejock Toolkit Pro
URL: http://forum.codejock.com/forum_posts.asp?TID=24273
Printed Date: 19 April 2024 at 8:06am
Software Version: Web Wiz Forums 12.04 - http://www.webwizforums.com

Topic: CXTPImageManagerIconHandle copy constructor

Posted By: Julianis
Subject: CXTPImageManagerIconHandle copy constructor
Date Posted: 22 February 2022 at 10:36am

We noticed that when using CXTPImageManagerIconHandle, the copy constructor doesnt duplicate the handles when copying from a non shared handle:

CXTPImageManagerIconHandle A;

// loads a HBITMAP in A, A.m_bClearHandles set to TRUE

A.CreateIconFromResource(MAKEINTRESOURCE(ID_XXXX), CSize(32, 32));

// copy constructor, members are simply copied, so handle from A ends up in B
// but B.m_bClearHandles = FALSE
CXTPImageManagerIconHandle B(A);

// frees up handle
A.Clear();

// at this stage B still reference an invalid HBITMAP

I just modifed the copy constructor to call CopyHandle() if (hHandle.m_bClearHandles == TRUE)

Is it a bug or is there a design issue i missed ?

Regards

Replies:

Posted By: astoyan
Date Posted: 08 March 2022 at 11:59am

It is definitely a bad design, but it was necessary to do so in order to preserve the backward compatibility with the legacy class implementation that did not support various icon types. Fixing that behavior in constructor will lead to a lot more problems for those who has lots of dependencies on that class for a while.

Regards,

Alexander

Posted By: Julianis
Date Posted: 09 March 2022 at 10:17am

Ok, thanks for the informations.

Regards