Toolkit Pro - compiler warning errors in XTToolkitPro.h

Print Page | Close Window

compiler warning errors in XTToolkitPro.h

Printed From: Codejock Forums
Category: Codejock Products
Forum Name: Toolkit Pro
Forum Description: Topics Related to Codejock Toolkit Pro
URL: http://forum.codejock.com/forum_posts.asp?TID=23223
Printed Date: 04 October 2024 at 9:26pm
Software Version: Web Wiz Forums 12.04 - http://www.webwizforums.com

Topic: compiler warning errors in XTToolkitPro.h

Posted By: adrien
Subject: compiler warning errors in XTToolkitPro.h
Date Posted: 06 December 2016 at 7:46pm

Hi Guys

Version 17.2, haven't checked if it's the same in 17.3 but my later comment probably applies still

In XTToolkitPro.h, there are changes made to compiler warnings before the warning state is pushed. So this means that after inclusion of this header, the state of the warning for name decoration length is changed.

Need to do the push before the change.

I would also strongly recommend enabling warning 4265 and checking all your virtual destructors. We recently found some memory leak problems around this, and by default 4265 is disabled, but it is very useful. We went through our code with this warning back on, but CodeJock woudln't build.

Since there are many cases where we derive from CJ classes, where (not sure) maybe the objects are destroyed via a base class pointer, virtual destructors are required to avoid leaks.

Cheers

Adrien

-------------
http://www.wingate.com - http://www.wingate.com

Replies:

Posted By: astoyan
Date Posted: 12 December 2016 at 7:49pm

Thanks for bringing this to our attention. The issue has been added to the bug database and hopefully will be addressed for 18.0.

Regards,

Alexander