Toolkit Pro - Toolkit Pro, Suite Pro 17.0.0 Beta 2

Print Page | Close Window

Toolkit Pro, Suite Pro 17.0.0 Beta 2

Printed From: Codejock Forums
Category: Codejock Products
Forum Name: Toolkit Pro
Forum Description: Topics Related to Codejock Toolkit Pro
URL: http://forum.codejock.com/forum_posts.asp?TID=22693
Printed Date: 25 December 2024 at 12:14am
Software Version: Web Wiz Forums 12.04 - http://www.webwizforums.com

Topic: Toolkit Pro, Suite Pro 17.0.0 Beta 2

Posted By: BeeJay
Subject: Toolkit Pro, Suite Pro 17.0.0 Beta 2
Date Posted: 21 August 2015 at 6:11am

Hi there,

after 3 hours of debugging our application after switching from Beta1 to Beta2 we finally found out, that there must have been a major change in your code/solution settings/whatever Ouch

    File: ..\..\Source\Ribbon\Themes\XTPRibbonThemeOffice2013.cpp
    Line: 189
    ASSERT(NULL != pThemeStaticExtension->FindExtension(L"Colors"));

always fails!

We found out, that the look-up in CXTPMarkupStaticExtension::m_mapExtensions, which uses CompareElements, does not use the
template<> inline BOOL AFXAPI CompareElements(const LPCWSTR* pElement1, const LPCWSTR* pElement2)
implementation locally defined in XTPMarkupStaticExtension.cpp, but the MFC built-in CompareElements default-implementation which does a pointer comparison and due to that always returns false.

Hence, there must have been some conceptual change compared to BETA1 where this ASSERT in your code worked well. We have no clue what it is.

The effect can be reproduced easly with your RibbonMDISample (Visual Studio 2013): We used UNICODE DEBUG Target with STATICALLY linking MFC+CRT and set Platform Toolset: Visual Studio 2013 - Windows XP (v120_xp)

Program: ...oolkit\ToolkitProv17.0.0.081715\bin\vc120\RibbonMDISample.exe
File: ..\..\Source\Ribbon\Themes\XTPRibbonThemeOffice2013.cpp
Line: 189

Being that, Beta2 is currently unusable as we need Ribbon integration. Cry

Sorry, guys...

Replies:

Posted By: Marco1
Date Posted: 21 August 2015 at 12:34pm

There's a small Problem with the Office 2007 calendar theme: The left borders are missing, especially in extended multi view:

And all Visual Studio 2015 themes assert in the CalendarDemo sample.

Testplatform: Win 10 / VS 2015

-------------
Product: XTP 18.3.0 on VS 2017
Platform: VS 2017 / Windows 10 (64bit)

Posted By: astoyan
Date Posted: 24 August 2015 at 10:46pm

The first report issue has been already fixed. I added the Calendar border bug into our bug tracking system.

As for the assertions in Calendar Demo, we're unable to get them. What is the configuration (debug/release/ansi/unicode/static/shared)? Can you also provide several callstacks for those assertions?

Thanks

Posted By: Marco1
Date Posted: 30 August 2015 at 8:50am

astoyan wrote:

As for the assertions in Calendar Demo, we're unable to get them. What is the configuration (debug/release/ansi/unicode/static/shared)? Can you also provide several callstacks for those assertions?

Sorry for being not precisely.
I'm compiling the source code of your CalendarDemo sample with VS2015 as UnicodeDebug. Your sample is dynamic linking.
Upon selecting any of the VS2015 themes the sample crashes. All other themes are fine.
Here is the call stack:

>    ucrtbased.dll!_VCrtDbgReportA(int nRptType, void * returnAddress, const char * szFile, int nLine, const char * szModule, const char * szFormat, char * arglist) Line 263    C++
     ucrtbased.dll!_CrtDbgReport(int report_type, const char * file_name, int line_number, const char * module_name, const char * format, ...) Line 258    C++
     ToolkitPro1700vc140UD.dll!AfxAssertFailedLine(const char * lpszFileName, int nLine) Line 333    C++
     ToolkitPro1700vc140UD.dll!CXTPMarkupThemePart::RenderMarkup(CDC * pDC, CRect rc) Line 122    C++
     ToolkitPro1700vc140UD.dll!CXTPRibbonMarkupFrameTheme::DrawFrameBorder(CDC * pDC, CXTPCommandBarsFrameHook * pFrameHook) Line 163    C++
     ToolkitPro1700vc140UD.dll!CXTPRibbonMarkupFrameTheme::DrawFrame(CDC * pDC, CXTPCommandBarsFrameHook * pFrameHook) Line 104    C++
     ToolkitPro1700vc140UD.dll!CXTPFrameThemeModernUI::DrawFrame(CDC * pDC, CXTPCommandBarsFrameHook * pFrameHook) Line 265    C++
     ToolkitPro1700vc140UD.dll!CXTPCommandBarsFrameHook::RedrawFrame() Line 612    C++
     ToolkitPro1700vc140UD.dll!CXTPCommandBarsFrameHook::OnHookMessage(HWND__ * hWnd, unsigned int nMessage, unsigned int & wParam, long & lParam, long & lResult) Line 1201    C++
     ToolkitPro1700vc140UD.dll!CXTPHookManager::CHookSink::OnHookMessage(HWND__ * hWnd, unsigned int nMessage, unsigned int & wParam, long & lParam, long & lResult) Line 298    C++
     ToolkitPro1700vc140UD.dll!CXTPHookManager::HookWndProc(HWND__ * hWnd, unsigned int message, unsigned int wParam, long lParam) Line 420    C++
     [External Code]    
     [Frames below may be incorrect and/or missing, no symbols loaded for user32.dll]    
     ToolkitPro1700vc140UD.dll!CXTPMarkupThemePart::RenderMarkup(CDC * pDC, CRect rc) Line 122    C++
     ToolkitPro1700vc140UD.dll!CXTPRibbonMarkupFrameTheme::DrawFrameBorder(CDC * pDC, CXTPCommandBarsFrameHook * pFrameHook) Line 163    C++
     ToolkitPro1700vc140UD.dll!CXTPRibbonMarkupFrameTheme::DrawFrame(CDC * pDC, CXTPCommandBarsFrameHook * pFrameHook) Line 104    C++
     ToolkitPro1700vc140UD.dll!CXTPFrameThemeModernUI::DrawFrame(CDC * pDC, CXTPCommandBarsFrameHook * pFrameHook) Line 265    C++
     ToolkitPro1700vc140UD.dll!CXTPCommandBarsFrameHook::OnHookMessage(HWND__ * hWnd, unsigned int nMessage, unsigned int & wParam, long & lParam, long & lResult) Line 1324    C++
     ToolkitPro1700vc140UD.dll!CXTPHookManager::CHookSink::OnHookMessage(HWND__ * hWnd, unsigned int nMessage, unsigned int & wParam, long & lParam, long & lResult) Line 298    C++
     ToolkitPro1700vc140UD.dll!CXTPHookManager::HookWndProc(HWND__ * hWnd, unsigned int message, unsigned int wParam, long lParam) Line 420    C++
     [External Code]    
     ToolkitPro1700vc140UD.dll!CXTPRibbonBar::EnableFrameTheme(int bEnable) Line 407    C++
     CalendarDemo.exe!CMainFrame::SetCommandBarsTheme(XTPPaintTheme paintTheme, const wchar_t * lpszINI) Line 864    C++
     CalendarDemo.exe!CMainFrame::SetTheme(int theme) Line 971    C++
     CalendarDemo.exe!CMainFrame::OnOptionsStyleVisualStudio2015(unsigned int nStyle) Line 455    C++
     [External Code]    
     ToolkitPro1700vc140UD.dll!CXTPCommandBarsSiteBase<CFrameWnd>::OnWndMsg(unsigned int message, unsigned int wParam, long lParam, long * pResult) Line 199    C++
     [External Code]    
     ToolkitPro1700vc140UD.dll!CXTPHookManager::HookWndProc(HWND__ * hWnd, unsigned int message, unsigned int wParam, long lParam) Line 428    C++
     [External Code]    
     ToolkitPro1700vc140UD.dll!NotifyExecute(CXTPControl * pControl, CWnd * pOwner) Line 333    C++
     ToolkitPro1700vc140UD.dll!CXTPControl::OnExecute() Line 558    C++
     ToolkitPro1700vc140UD.dll!CXTPControlButton::OnLButtonUp(CPoint __formal) Line 59    C++
     ToolkitPro1700vc140UD.dll!CXTPCommandBar::OnLButtonUp(unsigned int nFlags, CPoint point) Line 512    C++
     [External Code]    
     ToolkitPro1700vc140UD.dll!CXTPCommandBar::OnWndMsg(unsigned int message, unsigned int wParam, long lParam, long * pResult) Line 2590    C++
     [External Code]    
     ToolkitPro1700vc140UD.dll!CXTPHookManager::HookWndProc(HWND__ * hWnd, unsigned int message, unsigned int wParam, long lParam) Line 428    C++
     [External Code]    
     CalendarDemo.exe!wWinMain(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, wchar_t * lpCmdLine, int nCmdShow) Line 26    C++
     [External Code]

-------------
Product: XTP 18.3.0 on VS 2017
Platform: VS 2017 / Windows 10 (64bit)

Posted By: Marco1
Date Posted: 30 August 2015 at 9:16am

When running our application with 17 beta 2 and with Office2010 Blue theme, there are a lot of warnings about missing images and markups. Can you please add/fix them for this theme?!

Here are the single warnings in detail:

WARNING! File: 'OFFICE2010BLUE_INI', Section: [Images], Value: 'RIBBONGROUPSEPARATOR' was not defined.
WARNING! File: 'OFFICE2010BLUE_INI', Section: [Theme], Value: 'Compatibility' was not defined.
WARNING! File: 'OFFICE2010BLUE_INI', Section: [StatusBar], Value: 'TextColor' was not defined.
WARNING! File: 'OFFICE2010BLUE_INI', Section: [StatusBar], Value: 'TextGrayColor' was not defined.
WARNING! File: 'OFFICE2010BLUE_INI', Section: [StatusBar], Value: 'BackgroundColor' was not defined.
WARNING! File: 'OFFICE2010BLUE_INI', Section: [StatusBar], Value: 'GripperLite' was not defined.
WARNING! File: 'OFFICE2010BLUE_INI', Section: [StatusBar], Value: 'GripperDark' was not defined.
WARNING! File: 'OFFICE2010BLUE_INI', Section: [Images], Value: 'CONTROLGALLERYSCROLLARROWGLYPHSDARK' was not defined.

Thanx!

-------------
Product: XTP 18.3.0 on VS 2017
Platform: VS 2017 / Windows 10 (64bit)

Posted By: empty2fill
Date Posted: 01 September 2015 at 10:25pm

Hi.

Button Sample built with VS2015 does not display anything in Windows Classic theme.

While Button.exe process still running in Task Manager.

1. When built with VS2010 it works.
2. In Windows 7 Basic theme it works.

Is there something I missed?

Button Sample
: MFC\Xtreme ToolkitPro v17.0.0.081715\Samples\Controls\Button

Windows Classic theme
: Control Panel - Appearance and Personalization - Personalization - Theme - Windows Classic

Environment
: XTP 17.0.0 Beta 2 / VS2015 / Windows 7 64bit

Posted By: bigred9678
Date Posted: 04 September 2015 at 5:38pm

Hello,

After updating to the newest Beta version Xtreme ToolkitPro v17.0.0.081715, XTPMarkupImage is no longer rendering images. The FlowGraph sample program demonstrates this problem. Images are not rendering in Picture nodes or Table nodes, but the user card node seems to be working. This does not appear to be related to resources not loading. In my application, I am using the same bmp resource in other places. The most I have been able to track down is the "Source" property of the <Image> element could not be located.

Posted By: astoyan
Date Posted: 07 September 2015 at 10:58pm

This problem has already been fixed for the next update.

Posted By: BeeJay
Date Posted: 08 September 2015 at 2:38am

astoyan wrote:

This problem has already been fixed for the next update.

...which immediately leads to the question: WHEN will there be finally "the next update"?! Confused

Posted By: astoyan
Date Posted: 08 September 2015 at 10:36pm

We are conducting a thorough testing already, all the changes and fixes are already completed. We are just trying to avoid problems like those that we had with beta 2. I cannot provide a date, but it is going to be released very soon.

Posted By: Marco1
Date Posted: 09 September 2015 at 5:10am

You should really try to release Betas more frequently. Containing bugs is not an issue - cause it's a beta version. So, IMHO it would be helpful for CJ and us, the developers, to get public beta releases more often and as soon as some amount of bugs has been fixed.
Windows 10 beta phase was a good example how helpful frequent betas are.

-------------
Product: XTP 18.3.0 on VS 2017
Platform: VS 2017 / Windows 10 (64bit)

Posted By: JamesP
Date Posted: 16 September 2015 at 12:13pm

I'm currently looking at the 17.0.0 Beta 2 to look at making our ribbon applications High DPI aware.

I found a couple of issues.

I found an issue drawing icons on large split button popups when the scale is set to 125%. At this scale the room given for drawing the icon isn't enough so the bottom of the icon touches and even crosses the split. To get around this issue I changed a line of code in DrawControlToolBarParent function in the CXTPPaintManager class. The line works out the top left hand point where the icon should be drawn:

CPoint pt = bVert ? CPoint(rcButton.left + XTP_DPI_X(4) + nSplitDropDownHeight, rcButton.CenterPoint().y - szScalledIcon.cy / 2) :
CPoint(rcButton.CenterPoint().x - szScalledIcon.cx / 2, rcButton.top + XTP_DPI_Y(3));

I simply changed XTP_DPI_Y(3) to be XTP_DPI_Y(2), so as to give it a bit more room.

The final issue I found was at this same scaling level of 125%. I haven't looked into why it's happening but in some circumstance the tooltip text is being clipped at the bottom. Presumably the function to work out the text extent isn't giving the correct result. I had a look at the Codejock Ribbon Sample and the issue occurs on the Status Bar check box item on the View tab.

Posted By: JamesP
Date Posted: 16 September 2015 at 12:54pm

There was something else I found when enabling our ribbon applications to support high DPI, that I didn't expect.

Currently we provide two sizes of images, 16x16 for small ribbon buttons and 32x32 for large ribbon buttons.

To support high DPI monitors we scaled up the images we have by 1.5 and 2, but on running the application our small ribbon buttons were assumed to be large ribbon buttons and we got a very different layout with quite badly pixelated large buttons.

Looking into the code there's a function IsPrimaryImageExists that gets called in OnBeforeCalcSize. This function assumes that since you've provided a 32x32 image, it must be a large button.

I don't know if this is a bug.

To get around it we can simply not provide this image size for small buttons, or perhaps there's another way that I don't know about.