Public member variables...

Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic

   Why do you keep some member variables public? I think it's time to add those Get/Set-functions and hide them!
GetImageManager()->m_blabla ...
1) Bad design. Period!
2) It looks awful.
3) A Set-method makes it easier to debug variable assignments and a Get-method sure makes it a lot easier to track down where the variable is being used.

Member variables that cannot be subclassed should always be private and always accessed via the Get-function!

Author	Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic
znakeeye Members Profile Send Private Message Find Members Posts Add to Buddy List Senior Member Joined: 26 July 2006 Status: Offline Points: 1672	Post Options Post Reply Quote znakeeye Report Post Thanks(0) Quote Reply Topic: Public member variables... Posted: 31 October 2007 at 5:30am
	Why do you keep some member variables public? I think it's time to add those Get/Set-functions and hide them! GetImageManager()->m_blabla ... 1) Bad design. Period! 2) It looks awful. 3) A Set-method makes it easier to debug variable assignments and a Get-method sure makes it a lot easier to track down where the variable is being used. Member variables that cannot be subclassed should always be private and always accessed via the Get-function!