CXTPCommandBarAnimation::RedrawRect

Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic

   Looking at dump files where we crash in AlphaBlendU with a non-null pointer access violation, Claude Code has pointed to CXTPCommandBarAnimation::RedrawRect where lpRect == NULL.

CC thinks RemoveAnimations needs to be called there. I have verified debugging that if I have collapsed groups and click and move over etc. that function is called with a NULL lpRect. It is also called when we programmatically set the popup of a collapsed group with a "find command" tool we have. It is also called when clicking a button on the ribbon.

But still, I never crash. This is "random" in our code base. Can a CJ expert confirm or deny this change is needed:

void CXTPCommandBarAnimation::RedrawRect(LPCRECT lpRect, BOOL bAnimate)
{
    if (lpRect == NULL)
    {
        m_bmpCache.DeleteObject();
        RemoveAnimations();
    }

So far in testing I find nothing bad happening. So, I got that going for me.

Author	Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic
rdhd Members Profile Send Private Message Find Members Posts Add to Buddy List Senior Member Joined: 13 August 2007 Location: United States Status: Offline Points: 977	Post Options Post Reply Quote rdhd Report Post Thanks(0) Quote Reply Topic: CXTPCommandBarAnimation::RedrawRect Posted: 2 hours 27 minutes ago at 4:24pm
	Looking at dump files where we crash in AlphaBlendU with a non-null pointer access violation, Claude Code has pointed to CXTPCommandBarAnimation::RedrawRect where lpRect == NULL. CC thinks RemoveAnimations needs to be called there. I have verified debugging that if I have collapsed groups and click and move over etc. that function is called with a NULL lpRect. It is also called when we programmatically set the popup of a collapsed group with a "find command" tool we have. It is also called when clicking a button on the ribbon. But still, I never crash. This is "random" in our code base. Can a CJ expert confirm or deny this change is needed: void CXTPCommandBarAnimation::RedrawRect(LPCRECT lpRect, BOOL bAnimate) { if (lpRect == NULL) { m_bmpCache.DeleteObject(); RemoveAnimations(); } So far in testing I find nothing bad happening. So, I got that going for me.