TaskDialog infinite loop on an error case

Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic

   We are using an CXTPTaskDialog in our application.

I'm using incorrect settings and the dialog fails to create.
In this case the application ends up in an infinite loop.

The culprit seems to be the handling of the error case in 

int CXTPTaskDialogFrame::OnCreate(LPCREATESTRUCT lpCreateStruct)
{
  ...
  	if (!CreateClient(TRUE))
	{
		TRACE0("Failed to create Task Dialog UI window.\n");
		return FALSE;
	}

}

The return FALSE seems to be incorrect (the method returns 0 as success).

If I patch the code with a return -1 when CreateClient() fails, the infinite loop no longer happens.

Author	Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic
Julianis Members Profile Send Private Message Find Members Posts Add to Buddy List Newbie Joined: 23 March 2017 Status: Offline Points: 5	Post Options Post Reply Quote Julianis Report Post Thanks(0) Quote Reply Topic: TaskDialog infinite loop on an error case Posted: Yesterday at 5:54am
	We are using an CXTPTaskDialog in our application. I'm using incorrect settings and the dialog fails to create. In this case the application ends up in an infinite loop. The culprit seems to be the handling of the error case in int CXTPTaskDialogFrame::OnCreate(LPCREATESTRUCT lpCreateStruct) { ... if (!CreateClient(TRUE)) { TRACE0("Failed to create Task Dialog UI window.\n"); return FALSE; } } The return FALSE seems to be incorrect (the method returns 0 as success). If I patch the code with a return -1 when CreateClient() fails, the infinite loop no longer happens.