12.1.1 menu accelerator keys problem

Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic

   After upgrading to 12.1.1, I did a new install of our app and found that all of the accelerator keys were missing from the menu.

I traced it to  XTPShortcutManager.cpp.  At line 1416 in DoPropExchange, you're calling m_pAccelTable->RemoveAll() before checking to see if there is a saved accelerator table.  But the first time the app is run, there is no existing table, so the default accelerator table is destroyed and replaced with an empty one.  When the app exits, that empty table is saved, so the only way to ever get accelerator keys is to enter them manually in the customize menu dialog.

I made a change to move the RemoveAll() call down after nAccelSize is set; i.e.:

if (pPX->IsAllowBlobValues())

{

  int nAccelSize = (int)pPX->ReadCount();

  if ( nAccelSize ) {

    m_pAccelTable->RemoveAll();

    LPACCEL lpAccel = new ACCEL[nAccelSize];

    pPX->Read(_T("Data"), lpAccel, nAccelSize* sizeof(ACCEL));

    UpdateAcellTable(lpAccel, nAccelSize);

    delete[] lpAccel;

}

Author	Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic
rconn Members Profile Send Private Message Find Members Posts Add to Buddy List Groupie Joined: 16 May 2007 Location: United States Status: Offline Points: 79	Post Options Post Reply Quote rconn Report Post Thanks(0) Quote Reply Topic: 12.1.1 menu accelerator keys problem Posted: 31 December 2008 at 11:24pm
	After upgrading to 12.1.1, I did a new install of our app and found that all of the accelerator keys were missing from the menu. I traced it to XTPShortcutManager.cpp. At line 1416 in DoPropExchange, you're calling m_pAccelTable->RemoveAll() before checking to see if there is a saved accelerator table. But the first time the app is run, there is no existing table, so the default accelerator table is destroyed and replaced with an empty one. When the app exits, that empty table is saved, so the only way to ever get accelerator keys is to enter them manually in the customize menu dialog. I made a change to move the RemoveAll() call down after nAccelSize is set; i.e.: if (pPX->IsAllowBlobValues()) { int nAccelSize = (int)pPX->ReadCount(); if ( nAccelSize ) { m_pAccelTable->RemoveAll(); LPACCEL lpAccel = new ACCEL[nAccelSize]; pPX->Read(_T("Data"), lpAccel, nAccelSize* sizeof(ACCEL)); UpdateAcellTable(lpAccel, nAccelSize); delete[] lpAccel; }

Oleg Members Profile Send Private Message Find Members Posts Add to Buddy List Admin Group Joined: 21 May 2003 Location: United States Status: Offline Points: 11234	Post Options Post Reply Quote Oleg Report Post Thanks(0) Quote Reply Posted: 05 January 2009 at 2:02am
	Hi, Where you read customization from ? by default LoadCommandBars load it from registry and DoPropExchange not even called.
	Oleg, Support Team CODEJOCK SOFTWARE SOLUTIONS