[solved] Heap corruption 17.1

I integrated 17.1 into my projects and noticed a considerable amount of heap corruption going on.

I haven't had much opportunity to track exactly where the problems are happening but the new version is definitely unstable.

Noted indications of heap corruption in my application:

1. Last word of text is weirdly truncated in every MessageBox.
2. GIDPlus crashes in Flowgraph simply by opening a flowgraph.
3. Visual artifacts appear such as overdrawn lines, object placement.

These problems do not occur with v. 16.26. They only appear when I link with v. 17.1. The more complex the program, the more pronounced the issue. I typically use
"Yes (/LARGEADDRESSAWARE)" linker setting.

On their own, the individual components seem to have no error. All indications point to something in the new DPI processing system.. somewhere.

The nearest I could come to duplicating in a CJ sample was with CalendarDemo. This may or may not be related to the general condition, but the behavior is similar.

1. Build and run CalendarDemo using Static, Unicode settings. DLL seemed to produce the same results.

2. Select the test events.
3. Open options
4. Select Custom for tooltips from combobox
5. Move mouse cursor over an object with tool tips.

Heap will be corrupt in method: void CWnd::FilterToolTipMessage(MSG* pMsg)

        if ((tiHit.lpszText != LPSTR_TEXTCALLBACK) && (tiHit.hinst == 0))
            free(tiHit.lpszText);

There was nothing obvious through my brief code review to indicate why this is. It's abstracted enough to be difficult to tell. Someone with more familiarity with the code base might be able to find the problem more easily.

Build 17.1
Static Lib
Unicode
VS2010
Win 7 Pro Service Pack 1

I didn't try a VS 2015 theme, but did test with Office 2013. The theme didn't seem to matter with regard to the problems. I used several of the different "Office" themes with no apparent difference.

I've noticed a number of topics posted here that point to memory issues. The effects seem random depending on how each application allocates memory... everything from crashes on exit to lockups during operation.

markr - I concur with your findings. I've concluded it must be something with the skin manager hook.

More details on the FlowGraph crash that I can reproduce 100% of the time.

No nodes, no connection points, no mark up, nothing. A blank FlowGraph page (with grid) should appear. Instead the program crashes with heap corruption.

Ctor works fine, activation works fine. Go to draw it and it's broken badly.

The problem seems to surface from this method:

LRESULT WINAPI CXTPSkinManagerApiHook::OnHookCallWindowProcW(WNDPROC lpPrevWndFunc, HWND hWnd, UINT Msg, WPARAM wParam, LPARAM lParam)

Example:

void CXTPFlowGraphControl::OnPaint()
{
....
>>> Crash here        delete pDC;
....

Which is calling this:

CXTPFlowGraphDrawContextGdiPlus::~CXTPFlowGraphDrawContextGdiPlus()
{
    SAFE_DELETE(m_pActivePen);
    SAFE_DELETE(m_pActiveFont);

    for (int i = 0; i < m_nBrushCount; i++)
    {
>>>> Crash here        delete m_arrBrushes.pBrush;
    }

    delete m_pGraphics;
}

The skin system appears problematic with v17+.

Win 7 pro
VS 2010
Static unicode debug build
CJ v 17.2.0

Thanks for the fix astoyan. That corrected custom tooltips.