[solved] QAT controls won't draw with Office 2013

Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic

   We have upgraded to V 18.0.1. We use the office 2013 ribbon theme. Now I have yet another "breaking" change in this upgrade. CXTPRibbonbar::DrawCommandBar used to call the Draw method on the controls on the QAT. But now there is a CXTPRibbonOffice2013Theme::DrawQuickAccessControl.

In that method, the code looks to see if the control has an icon. If it does not, it simply exits! The result is the customers that have QAT entries that have text but no icon see nothing. There are just big gaps where the controls would draw. The measure/sizing code cares nothing about the icon not existing and measures the text size, hence the gaps I see where the controls should be drawing.

IN V17, like with Microsoft Office 2013, controls that only have text would draw the text just fine. So why has CJ broken something that has worked for a number of years? Is this a bug? If so, is it fixed in a later release like 18.3?

Breaking changes like this are quite frustrating :( Upgrading CJ should be as smooth as upgrading to a new Visual Studio MFC version.

Author	Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic
rdhd Members Profile Send Private Message Find Members Posts Add to Buddy List Senior Member Joined: 13 August 2007 Location: United States Status: Offline Points: 891	Post Options Post Reply Quote rdhd Report Post Thanks(1) Quote Reply Topic: [solved] QAT controls won't draw with Office 2013 Posted: 01 December 2017 at 10:43am
	We have upgraded to V 18.0.1. We use the office 2013 ribbon theme. Now I have yet another "breaking" change in this upgrade. CXTPRibbonbar::DrawCommandBar used to call the Draw method on the controls on the QAT. But now there is a CXTPRibbonOffice2013Theme::DrawQuickAccessControl. In that method, the code looks to see if the control has an icon. If it does not, it simply exits! The result is the customers that have QAT entries that have text but no icon see nothing. There are just big gaps where the controls would draw. The measure/sizing code cares nothing about the icon not existing and measures the text size, hence the gaps I see where the controls should be drawing. IN V17, like with Microsoft Office 2013, controls that only have text would draw the text just fine. So why has CJ broken something that has worked for a number of years? Is this a bug? If so, is it fixed in a later release like 18.3? Breaking changes like this are quite frustrating :( Upgrading CJ should be as smooth as upgrading to a new Visual Studio MFC version.

rdhd Members Profile Send Private Message Find Members Posts Add to Buddy List Senior Member Joined: 13 August 2007 Location: United States Status: Offline Points: 891	Post Options Post Reply Quote rdhd Report Post Thanks(1) Quote Reply Posted: 01 December 2017 at 4:59pm
	I just traced another problem down where users are claiming they cannot see the drop arrow on popup controls we build into the QAT. Our undo/redo (added out-of-the-box) to the QAT have no drop arrows. You can click where they reside and the control will pop. If I customize and add a popup control from the ribbon to the QAT, you can see the same thing. My code change to DraqQuickAccessControl where I comment out all the code except the call to pControl->Draw fixes that too. The user work-around until I roll this out is to move the QAT so it is below the ribbon.

olebed Members Profile Send Private Message Find Members Posts Add to Buddy List Admin Group Joined: 01 July 2014 Location: Ukraine Status: Offline Points: 841	Post Options Post Reply Quote olebed Report Post Thanks(0) Quote Reply Posted: 05 December 2017 at 10:03pm
	Hello rdhd, Thank you for bringing this to our attention. I have added this to our task list for next release. Regards, Oleksandr Lebed