Office2007 theme inconsistent

Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic

   in 

void CXTPReportPaintManager::RefreshMetrics()

you can see that for m_nColumnStyle == xtpReportColumnOffice2007, it picks column header colours based on the current system colour (luna) setting.

No other controls do this (i.e. command bars, window frame etc).

I propose for consistency, that the code 

   switch (XTPColorManager()->GetCurrentSystemTheme())
   {
    case xtpSystemThemeSilver:
    {
...
     }
   }

be replaced simply with the colour lookups using

XTPOffice2007Images()->GetImageColor(_T("Window"), _T("WindowFrame"))

otherwise we have small parts of a GUI of an app which change colour with the windows theme, and most doesn't (or is this the behaviour of the office apps themselves?)

Author	Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic
adrien Members Profile Send Private Message Find Members Posts Add to Buddy List Senior Member Joined: 30 April 2007 Location: New Zealand Status: Offline Points: 449	Post Options Post Reply Quote adrien Report Post Thanks(0) Quote Reply Topic: Office2007 theme inconsistent Posted: 26 February 2008 at 4:19pm
	in void CXTPReportPaintManager::RefreshMetrics() you can see that for m_nColumnStyle == xtpReportColumnOffice2007, it picks column header colours based on the current system colour (luna) setting. No other controls do this (i.e. command bars, window frame etc). I propose for consistency, that the code switch (XTPColorManager()->GetCurrentSystemTheme()) { case xtpSystemThemeSilver: { ... } } be replaced simply with the colour lookups using XTPOffice2007Images()->GetImageColor(_T("Window"), _T("WindowFrame")) otherwise we have small parts of a GUI of an app which change colour with the windows theme, and most doesn't (or is this the behaviour of the office apps themselves?)

adrien Members Profile Send Private Message Find Members Posts Add to Buddy List Senior Member Joined: 30 April 2007 Location: New Zealand Status: Offline Points: 449	Post Options Post Reply Quote adrien Report Post Thanks(0) Quote Reply Posted: 26 February 2008 at 5:54pm
	or in front of that add if (XTPOffice2007Images()->IsValid()) { m_grcGradientColumn.SetStandardValue(XTPOffice2007Images()->GetImageColor(_T("Toolbar"), _T("ToolbarFaceLight")), XTPOffice2007Images()->GetImageColor(_T("Toolbar"), _T("ToolbarFaceDark")), 0.25f); m_grcGradientColumnPushed.SetStandardValue(XTPOffice2007Images()->GetImageColor(_T("Toolbar"), _T("ToolbarFaceDark")), XTPOffice2007Images()->GetImageColor(_T("Toolbar"), _T("ToolbarFaceLight")), 0.25f); // shadow on the bottom of the column headers. m_clrGradientColumnShadow.SetStandardValue(XTPOffice2007Images()->GetImageColor(_T("Toolbar"), _T("ControlEditBorder"))); // this is the column separator. m_clrGradientColumnSeparator.SetStandardValue(XTPOffice2007Images()->GetImageColor(_T("Toolbar"), _T("ToolbarGripper"))); // group box background should be same as workspace? m_clrGroupBoxBack.SetStandardValue(XTPOffice2007Images()->GetImageColor(_T("Workspace"), _T("AppWorkspace"))); m_crlNoGroupByText.SetStandardValue(XTPOffice2007Images()->GetImageColor(_T("Window"), _T("CaptionTextActive"))); m_clrGroupShadeBack.SetStandardValue(XTPOffice2007Images()->GetImageColor(_T("Toolbar"), _T("ToolbarFaceLight"))); // hot is for a column header that is being dragged m_grcGradientColumnHot.SetStandardValue(m_grcGradientColumn); m_clrGroupRowText.SetStandardValue(XTPOffice2007Images()->GetImageColor(_T("ShortcutBar"), _T("NormalText"))); m_clrGroupShadeBorder.SetStandardValue(m_clrGradientColumnSeparator); } else {

Oleg Members Profile Send Private Message Find Members Posts Add to Buddy List Admin Group Joined: 21 May 2003 Location: United States Status: Offline Points: 11234	Post Options Post Reply Quote Oleg Report Post Thanks(0) Quote Reply Posted: 27 February 2008 at 6:43am
	Thanks, Adrien Blue, Black and Silver themes added for Report for 12.0 release.
	Oleg, Support Team CODEJOCK SOFTWARE SOLUTIONS

adrien Members Profile Send Private Message Find Members Posts Add to Buddy List Senior Member Joined: 30 April 2007 Location: New Zealand Status: Offline Points: 449	Post Options Post Reply Quote adrien Report Post Thanks(0) Quote Reply Posted: 27 February 2008 at 8:23am
	actually what would be really cool, would be if a) the hot gradient colour was used when hovering (like a CListCtrl), and b) it was that cool orange gradient that's used on the Toolbar buttons (for the Office 2007 Black theme anyway) Cheers Adrien