Decide you for optimizing for speed or secure code

Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic

   While debugging I stepped about following code in

void CXTPReportControl::OnDraw(CDC* pDC)

CXTPReportHeader* pHeader = GetReportHeader();

CRect rcHeader = m_rcHeaderArea;
rcHeader.right = rcHeader.left + pHeader->GetWidth();

// draw header
if (pHeader)
   pHeader->Draw(pDC, rcHeader, m_nLeftOffset);

// draw group by box
if (pHeader)
   pHeader->DrawGroupByControl(pDC, m_rcGroupByArea);

Optimizing I:

if (pHeader)
{
   pHeader->Draw(pDC, rcHeader, m_nLeftOffset);

   pHeader->DrawGroupByControl(pDC, m_rcGroupByArea);
}

Optimizing II:

pHeader->Draw(pDC, rcHeader, m_nLeftOffset);
pHeader->DrawGroupByControl(pDC, m_rcGroupByArea);

Because if pHeader is really null, then it crash already in line above (pHeader->GetWidth();) 

A a nice day