CXTPReportPaintManager::SetGridStyle

Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic

Hello,

the function is defined as:

CXTPReportPaintManager::SetGridStyle(BOOL bVertical, XTPReportGridStyle gridStyle)

Using a BOOL for the orientation is poor in my opinion and makes the code harder to read.

Please overload it as:

enum XTPReportGridOrientation
{
    xtpReportGridOrientationVertical,
    xtpReportGridOrientationHorizontal,
    xtpReportGridOrientationBoth

};

CXTPReportPaintManager::SetGridStyle(XTPReportGridOrientation orientation, XTPReportGridStyle gridStyle)

Leave the old method for backwards compatibility, mark it as deprecated and get rid of it in the next version.

Author	Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic
ABuenger Members Profile Send Private Message Find Members Posts Add to Buddy List Newbie Joined: 02 February 2006 Status: Offline Points: 1075	Post Options Post Reply Quote ABuenger Report Post Thanks(0) Quote Reply Topic: CXTPReportPaintManager::SetGridStyle Posted: 27 July 2010 at 5:43pm
	Hello, the function is defined as: CXTPReportPaintManager::SetGridStyle(BOOL bVertical, XTPReportGridStyle gridStyle) Using a BOOL for the orientation is poor in my opinion and makes the code harder to read. Please overload it as: enum XTPReportGridOrientation { xtpReportGridOrientationVertical, xtpReportGridOrientationHorizontal, xtpReportGridOrientationBoth }; CXTPReportPaintManager::SetGridStyle(XTPReportGridOrientation orientation, XTPReportGridStyle gridStyle) Leave the old method for backwards compatibility, mark it as deprecated and get rid of it in the next version.
	Codejock support