[BUG] MinimumWidth Columns

What is your expectaction in this case: you force some columns to have width >= min width. If result not fit - you suppose to extend form size (or I can auto change mode to use scrollbar?). What if you not set AutoColumnSizing?

Hi, Aaron, I see the problem in the case and will fix it. Btw - your sample treats by small modification:

Hi Aaron - I already did it couple days ago

uploads/20090220_155842_ReportSampleSat.rar

Hi, as a test case I upload current version of MFC ReportSample where you can try all new features:

Hi, Aaron, could you run my static MFC ReportSample and check TaskListView - it show desired Layout Adjustment:

Hi, Aaron,

wndReport.AddColumn(new CXTPReportColumn(COLUMN_TYPE, _T("Type"), 18, bAllowSize, 0));

all columns use wndReport.GetColumns()->GetAt(iC)->SetMinWidth(100); (in loop)

it's all - other settings - defaults (m_bAutoColumnSizing = TRUE) plus cosmetic:

I've noticed a problem where the Horizontal scrollbar doesn't appear when AutoColumnSizing = True but the ReportControl width is less than the total columns width after calling BestFit on the columns. It sounds like this may have been fixed (based on posts above), but I'm not sure (I can't get the latest ReportControl to work in the IDE). Has this been fixed?

I found another problem with the MinimumWidth property (in 13.0 and the ReportControl.ocx linked above).

This code:

For i = 0 To .Columns.Count - 1          With .Columns(i)               .MinimumWidth = UserControl.TextWidth(.Caption) \ Screen.TwipsPerPixelX + 5          End With       Next i

Produces the correct (or at least expected) result of:



Modifying the code to set the minimum width 1 pixel or more wider:

For i = 0 To .Columns.Count - 1          With .Columns(i)               .MinimumWidth = UserControl.TextWidth(.Caption) \ Screen.TwipsPerPixelX + 6          End With       Next i

Produces this result:




The first two columns have the AutoSize property set to False, the Subject column has AutoSize set to True and the two icon columns have AutoSize and Resizable properties set to False.

If you subsequently try to resize the too short columns, they will snap to the expected minimum width.

Hi Aaron,

I haven't been able to reproduce the scrollbar width too short problem yet...I'll keep trying (I forget the exact combination of settings that caused that problem yet). I have been able to reproduce some other bugs with the following sample:

SEE UPDATED SOURCE FIVE POSTS DOWN

Try the sample project after registering the ReportControl.ocx that Mark provided and compare to the 13.0 ReportControl. Here are the problems (and steps required to reproduce them):

1. Resize window to minimum width, and then resize wider...the AutoSize for the "Subject" column is now broken (this doesn't happen in 13.0)
2. Set the mc_MinimumWidthPaddingPx constant in the FiveOutbox.ctl file 6 and the mc_AutoColumnSizing constant to True and re-run the project. The column widths are now broken.
3. Remove the comment character (') from the mc_SampleRecipients constant in the FiveOutbox.ctl file (to get multi-line recipients) and re-run the project. The BestFit method on the Recipients column measures the width of all 3 lines instead of just the longest line.
4. Set the mc_MinimumWidthPaddingPx constant to 6 and set the mc_AutoColumnSizing constant the False, and the re-run the project. The "Date Written" column is missing. In 13.0 the problems are even worse (columns missing, column dividers missing). Change the mc_MinimumWidthPaddingPx back to 5 and everything looks OK.
   

Another problem:

Remove the comment character (') from the mc_SampleRecipients constant in the FiveOutbox.ctl file (to get multi-line recipients) and re-run the project. No horizontal scrollbar appears. Start resizing the form width smaller...eventually the Horizontal scrollbar will appear. Now resizing the form width smaller and larger, and the Horizontal scrollbar appears to be working as expected.

You project is full of foreign controls. Get rid of them and make real test case with nothing else except standard VB and CJ Report Control ActiveX please

OK - now project works, all your sizing constant (for min values) are funny small as you are working not in pixel space. Why so name test case for resizing need UserControl - could you have same effect with ReportControl be direct part of form? You resizing function does not show control position during resizing - change it e.g. as I did - now I am sure that it properly fill form after form size changed:

This is beta-version of RC ActiveX from May02 - it will work till June 01:

 

Essentially there is nothing wrong in UserControl layout inside the form - in my settings it show 100% proper resize

I still not understand - you are still playing with 13.0? Did you tried attached 13.1 version?

I don't know how you handle internal recising of Report Control inside UserControl - please give more details. May be the problem is there?

Sorry, I think I may have found my mistake...I forgot to call BestFit in UserControl...will test and get back to you.

Okay, calling BestFit means the UserControl and Form-only RC match on startup. Sorry for the mistake. There are still some problems though.

1) At startup, the horizontal scrollbar is not visible even though 1 column is off the edge of the visible area:




2) After shrinking the form width slightly, the UserControl and Form-only RC column widths get out of sync (but all columns are visible as expected):



3) If you shrink the form width further, the right-most column is off the edge of the visible area, but there is still no horizontal scrollbar:



4) If you shrink the form width further, you will eventually get a horizontal scrollbar (it will have the correct scrolling width available, that is when you scroll it to the right, the rightmost column will be visible as expected):

I should add that the problem appears to be with the Multiline calculations. If you run the included RCRedrawSingleLine.exe everything appears to work as expected.

I've tested the May 2, 2009 build on Windows Vista and Windows 2000 - both OSes exhibit the same problematic behaviour (as shown in the screenshots). Are you testing with the EXEs or source code that I provided? Or on a different OS? Or a newer build?

I just tested on an XP SP3 machine that never had CJ controls installed, and only registered the May 2, 2009 OCX. Same problems as shown in the screenshots for the RCRedrawMultiline EXE. Are you using a newer build?

Maybe somebody else could confirm or deny the problem?

It's the same code...just modify the mc_SampleRecipients constant in Module1.bas to use multiple lines (remove the comment character). I'll open a support issue now.

See - I changed ONE LINE in your USER CONTROL code and now it works - this is a problem with YOUR RESIZING CODE I asked

Private Sub UserControl_Resize()
   With UserControl.ReportControl1
      .Move 0, 0, UserControl.ScaleWidth, UserControl.ScaleHeight
   End With
   UserControl.Refresh
End Sub

 

He just need to call UserControl.Refresh I did it for ONE control in his form and don't touch it's duplicate - and we behave differently now

Hi Aaron,
Thanks for the intervention 

I have no problem with the RowHeight, as you have mentioned, that is working fine.

The problems are with the column widths (BestFit) for columns with cells with multiple lines of text (not word wrap mode, just vbNewline characters) and missing Horizontal scroll bars. There  also seems to be a mysterious difference between the column sizing when the RC is on a Form and when it is on a UserControl (see screenshots and sample above). If you have a chance, you can tell me if I am going crazy, or if there is indeed a problem.

Thanks.

jpbro wrote: Hi Aaron, Thanks for the intervention  1.          I have no problem with the RowHeight, as you have mentioned, that is working fine. 2.          The problems are with the column widths (BestFit) for columns with cells with multiple lines of text (not word wrap mode, just vbNewline characters) and 3.          Missing Horizontal scroll bars.   4.          There  also seems to be a mysterious difference between the column sizing when the RC is on a Form and when it is on a UserControl (see screenshots and sample above).   5.          If you have a chance, you can tell me if I am going crazy, or if there is indeed a problem. Thanks.

Hi Jason,

Mark has updated the source to meet my expectations of the RC behaviour. In addition to these changes, some lessons learned/recommendations:

1) Call UserControl.Refresh after calling the Move method of a ReportControl on a UserControl.
2) Don't prepare your ReportControl (when on a UserControl) in the UserControl_Initialized event, instead create a public sub and call it from Form_Load.
3) When using RC on a UserControl, it is recommended to set the ScaleMode to vbPixels (if only for easier debugging since RC uses pixels exclusively for its internal measurements).

Thanks again to Mark and Aaron for working on this problem.

Hi,

Hi Mark,

    Thanks for the clarifications, they were very helpful. In case anyone is interested, here's a routine that is useful for adding columns to a ReportControl, using Mark's suggestion of setting the starting width to slightly less than the Minimum width:
    

Private Function AddColumn(ByRef p_ReportControl As ReportControl, ByVal p_Caption As String, ByVal p_MinimumWidthPx As Long, ByVal p_Resizable As Boolean, ByVal p_AutoSize As Boolean) As ReportColumn    ' This is a generic function for adding columns to the ReportControl    ' It bases the starting column width on the passed miminum column width as suggested by Mark Doubson @ Codejock    ' See http://forum.codejock.com/forum_posts.asp?TID=13379&PID=48715#48715    ' It also ensures that the column ItemIndex is correct by basing it on the column count at the time the column is added       With p_ReportControl       Set AddColumn = .Columns.Add(.Columns.Count, p_Caption, p_MinimumWidthPx - 10, p_Resizable)       With AddColumn          .AutoSize = p_AutoSize          .MinimumWidth = p_MinimumWidthPx       End With    End With End Function

    It returns the newly added column so that you can easily set and additional properties as required.

    In other news, I have isolated what appears to be a problem with the horizontal scrollbar appearance under a specific circumstance. If a column has its Resizable property set to True, and its AutoSize property set to False, then the HSB doesn't appear when you would expect it to.
   
    Here's a sample that demonstrates this problem:
   
uploads/20090507_210333_ReportControlRe.zip
   
    In the sample, there are 2 ReportControls (upper and lower). The only difference between them is that in the upper RC, the DateWritten column has the Resizable property set to True, while the lower RC has the Resizable property set to False. The upper RC doesn't show the horizontal scrollbar immediately after the right-most column extends beyond the visible area of the control, while the lower RC works perfectly. My best guess is that the algorithm used to determine visibility of the HSB is basing the decision on the MinimumWidth of the column instead of the displayed width of the column, but I'm not 100% sure of this.

     I'll just think out-loud here for a moment - Maybe a BeforeColumnResize event would be useful, because then we could manage minimum widths, maximum widths and resizability ourselves based on dynamic requirements at runtime. Something like: BeforeColumnResize(Column As ReportColumn, Cancel As Boolean). Setting Cancel to True would prevent the column from being resized by the user.

    Mark - If you prefer to do this through the support system, I can open a new ticket.