Bug in CXTPTabClientWnd::UpdateContents().

Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic

   I think you have a bug in method:
void CXTPTabClientWnd::UpdateContents().

The method contains the following code:

if ((pChildWnd->GetStyle() & WS_VISIBLE) == WS_VISIBLE)
{
// add item

pNewItem = pFoundItem = AddItem(pChildWnd);
pFoundItem->m_hWnd = pChildWnd->GetSafeHwnd();
pFrameWnd->SendMessage(WM_XTP_NEWTABITEM, (WPARAM)pNewItem);
pNewItem->GetTabManager()->SetSelectedItem(pNewItem);
}

Method AddItem(pChildWnd) may return NULL (and I really got it!). In this case my application raises Access Violation on the next line because pFoundItem=NULL. So verification for NULL is needed:

if ((pChildWnd->GetStyle() & WS_VISIBLE) == WS_VISIBLE)
{
// add item

   pNewItem = pFoundItem = AddItem(pChildWnd);

   if (pFoundItem)
   {
      pFoundItem->m_hWnd = pChildWnd->GetSafeHwnd();
      pFrameWnd->SendMessage(WM_XTP_NEWTABITEM, (WPARAM)pNewItem);
      pNewItem->GetTabManager()->SetSelectedItem(pNewItem);

   }
}

This code works fine!

Author	Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic
Sergey Members Profile Send Private Message Find Members Posts Add to Buddy List Newbie Joined: 15 November 2004 Status: Offline Points: 18	Post Options Post Reply Quote Sergey Report Post Thanks(0) Quote Reply Topic: Bug in CXTPTabClientWnd::UpdateContents(). Posted: 19 June 2006 at 8:57am
	I think you have a bug in method: void CXTPTabClientWnd::UpdateContents(). The method contains the following code: if ((pChildWnd->GetStyle() & WS_VISIBLE) == WS_VISIBLE) { // add item pNewItem = pFoundItem = AddItem(pChildWnd); pFoundItem->m_hWnd = pChildWnd->GetSafeHwnd(); pFrameWnd->SendMessage(WM_XTP_NEWTABITEM, (WPARAM)pNewItem); pNewItem->GetTabManager()->SetSelectedItem(pNewItem); } Method AddItem(pChildWnd) may return NULL (and I really got it!). In this case my application raises Access Violation on the next line because pFoundItem=NULL. So verification for NULL is needed: if ((pChildWnd->GetStyle() & WS_VISIBLE) == WS_VISIBLE) { // add item pNewItem = pFoundItem = AddItem(pChildWnd); if (pFoundItem) { pFoundItem->m_hWnd = pChildWnd->GetSafeHwnd(); pFrameWnd->SendMessage(WM_XTP_NEWTABITEM, (WPARAM)pNewItem); pNewItem->GetTabManager()->SetSelectedItem(pNewItem); } } This code works fine!