Crash in CXTColorPopup

Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic

   Xtreme Toolkit Pro v11.2.1 on Vista

CXTColorPopup in MDI applications crashes on closing "More Colors..." dialog which was opened from the popup.

To reproduce the crash take CCustomItemColor from "PropertyGrid\GridSample" sample and add it to Property Grid in "PropertyGrid\DrawClient" sample. Open the color popup, choose "More Colors...", the dialog opens but the popup closes (which is different from behavior in "PropertyGrid\GridSample") and once you close the dialog you'll get the crash.

Also, CXTColorPopup sends two CPN_XT_SELENDCANCEL if it closed by clicking on a different window, once from CXTColorPopup::OnKillFocus and once from CXTColorPopup::OnActivateApp, and it can be reproduced in "PropertyGrid\GridSample" sample by adding corresponding handle in CCustomItemColorPopup.

Thanks.

Author	Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic
Silvery Members Profile Send Private Message Find Members Posts Add to Buddy List Groupie Joined: 21 September 2007 Status: Offline Points: 11	Post Options Post Reply Quote Silvery Report Post Thanks(0) Quote Reply Topic: Crash in CXTColorPopup Posted: 16 November 2007 at 5:58pm
	Xtreme Toolkit Pro v11.2.1 on Vista CXTColorPopup in MDI applications crashes on closing "More Colors..." dialog which was opened from the popup. To reproduce the crash take CCustomItemColor from "PropertyGrid\GridSample" sample and add it to Property Grid in "PropertyGrid\DrawClient" sample. Open the color popup, choose "More Colors...", the dialog opens but the popup closes (which is different from behavior in "PropertyGrid\GridSample") and once you close the dialog you'll get the crash. Also, CXTColorPopup sends two CPN_XT_SELENDCANCEL if it closed by clicking on a different window, once from CXTColorPopup::OnKillFocus and once from CXTColorPopup::OnActivateApp, and it can be reproduced in "PropertyGrid\GridSample" sample by adding corresponding handle in CCustomItemColorPopup. Thanks.

Oleg Members Profile Send Private Message Find Members Posts Add to Buddy List Senior Member Joined: 21 May 2003 Location: United States Status: Offline Points: 11234	Post Options Post Reply Quote Oleg Report Post Thanks(0) Quote Reply Posted: 17 November 2007 at 12:44am
	Hi, Thanks, can you please patch sources - in CXTColorPopup::OnKillFocus replace if (!IsColorDlgVisible()) { EndSelection(-1); } to if (!m_pColorDlg) { EndSelection(-1); }
	Oleg, Support Team CODEJOCK SOFTWARE SOLUTIONS

Silvery Members Profile Send Private Message Find Members Posts Add to Buddy List Groupie Joined: 21 September 2007 Status: Offline Points: 11	Post Options Post Reply Quote Silvery Report Post Thanks(0) Quote Reply Posted: 17 November 2007 at 2:17am
	Thanks, the patch fixed the crash. Besides CPN_XT_SELENDCANCEL being sent twice on canceling the popup, CPN_XT_SELENDCANCEL event is also sent after CPN_XT_SELENDOK event on selection of a color.