Change to recurring (AKA Yet another bug fix)

Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic

   This should only an issue when using the MAPI data provider (I didn't test the other, so I can't be 100% sure.)

In xtpcalendarmapidataprovider.cpp at line 3542 we are inside the MAPI callback, dealing with the fact that the event changed, and updating the cache. On this line, there is a silly mistake.

ptrEvent2->SetRecurrencePatternID(dwPatternID);
the pattern ID was just grabbed from another event pointer, and now it is being coppied over to this one. This is fine, except that in this case, the old event HAD no pattern ID, and the new one does. This causes the code inside _AddRPatternWithExceptions (called by ChangeEvent which is called on the next line) to fail when it assumes that we DO have an ID. The fix is fairly basic.

if (dwPatternID != XTP_CALENDAR_UNKNOWN_RECURRENCE_PATTERN_ID)
{
    ptrEvent2->SetRecurrencePatternID(dwPatternID);
}