CXTButton and focus rectangle

Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic

   Noticed that CXTButton tends to loose focus rectangle(all correct styles are set). If button is clicked focus rectangle appears. But if window containing that button is deactivated and activated again focus rectangle is gone. That button is still focused but no focus rectangle. Investigated whats going under the hood and found problem in void CXTButtonTheme::DrawItem(LPDRAWITEMSTRUCT lpDIS, CXTButton* pButton)

this part:

 // Draw the focus rect if style is set and we have focus.
 if ((pButton->GetXButtonStyle() & BS_XT_SHOWFOCUS))
 {
  if (lpDIS->itemAction & ODA_FOCUS)
  {
   DrawFocusRect(pDC, nState, rcItem, pButton);
  }
 }

should look like this:
 if ((pButton->GetXButtonStyle() & BS_XT_SHOWFOCUS))
 {
  if (lpDIS->itemState & ODS_FOCUS && (lpDIS->itemState & 0x0200/*ODS_NOFOCUSRECT*/) == 0)
  {
   DrawFocusRect(pDC, nState, rcItem, pButton);
  }
 }

Because when drawitem message is generated with itemAction == ODA_DRAWENTIRE   no focus rectangle is drawn at all.

Author	Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic
Kukis Members Profile Send Private Message Find Members Posts Add to Buddy List Newbie Joined: 24 May 2006 Status: Offline Points: 11	Post Options Post Reply Quote Kukis Report Post Thanks(0) Quote Reply Topic: CXTButton and focus rectangle Posted: 22 February 2007 at 10:56am
	Noticed that CXTButton tends to loose focus rectangle(all correct styles are set). If button is clicked focus rectangle appears. But if window containing that button is deactivated and activated again focus rectangle is gone. That button is still focused but no focus rectangle. Investigated whats going under the hood and found problem in void CXTButtonTheme::DrawItem(LPDRAWITEMSTRUCT lpDIS, CXTButton* pButton) this part: // Draw the focus rect if style is set and we have focus. if ((pButton->GetXButtonStyle() & BS_XT_SHOWFOCUS)) { if (lpDIS->itemAction & ODA_FOCUS) { DrawFocusRect(pDC, nState, rcItem, pButton); } } should look like this: if ((pButton->GetXButtonStyle() & BS_XT_SHOWFOCUS)) { if (lpDIS->itemState & ODS_FOCUS && (lpDIS->itemState & 0x0200/ODS_NOFOCUSRECT/) == 0) { DrawFocusRect(pDC, nState, rcItem, pButton); } } Because when drawitem message is generated with itemAction == ODA_DRAWENTIRE no focus rectangle is drawn at all.

Oleg Members Profile Send Private Message Find Members Posts Add to Buddy List Senior Member Joined: 21 May 2003 Location: United States Status: Offline Points: 11234	Post Options Post Reply Quote Oleg Report Post Thanks(0) Quote Reply Posted: 23 February 2007 at 1:54am
	Hello, Thanks, we agree this bug. Fixed for next release.
	Oleg, Support Team CODEJOCK SOFTWARE SOLUTIONS