![]() |
Markup bug in beta 14 |
Post Reply ![]() |
Author | |
adrien ![]() Senior Member ![]() Joined: 30 April 2007 Location: New Zealand Status: Offline Points: 449 |
![]() ![]() ![]() ![]() ![]() Posted: 18 February 2010 at 1:13am |
Hi
We're using markup to create some buttons. We get the callback when the button is clicked, but for some reason the CJ framework messed with the tag we had on the element (inserted a semicolon into it). The tag names are using a URI format for an internal action so they can get longish (about 60chars). This was introduced in 14.0 beta (original and latest). |
|
![]() |
|
adrien ![]() Senior Member ![]() Joined: 30 April 2007 Location: New Zealand Status: Offline Points: 449 |
![]() ![]() ![]() ![]() ![]() |
OK, I think I found the problem.
Using VSS to do a diff on XTPMarkupParser.cpp, there are only 2 diffs between 13.2.1 and 14.0.0 beta. IN CXTPMarkupParser::TokenType CXTPMarkupParser::ScanHead() line 205 if (c == '&') c = ScanEntity(); was added. ScanEntity returns ';' if not an entity. We have ampersands in our tag values (since it's a URL with query string). I don't think you should be trying to parse entities out of tag values? Probably not any values. Anything between quotes shouldn't be parsed? |
|
![]() |
|
adrien ![]() Senior Member ![]() Joined: 30 April 2007 Location: New Zealand Status: Offline Points: 449 |
![]() ![]() ![]() ![]() ![]() |
yep, that's definitely it. It inserted the ';' about 31 chars after the &
|
|
![]() |
|
adrien ![]() Senior Member ![]() Joined: 30 April 2007 Location: New Zealand Status: Offline Points: 449 |
![]() ![]() ![]() ![]() ![]() |
OK, looks like my bad.
Looks like ampersands must be escaped. |
|
![]() |
|
adrien ![]() Senior Member ![]() Joined: 30 April 2007 Location: New Zealand Status: Offline Points: 449 |
![]() ![]() ![]() ![]() ![]() |
looks like they must not be escaped in prior versions though.... hmmm
|
|
![]() |
Post Reply ![]() |
|
Tweet
|
Forum Jump | Forum Permissions ![]() You cannot post new topics in this forum You cannot reply to topics in this forum You cannot delete your posts in this forum You cannot edit your posts in this forum You cannot create polls in this forum You cannot vote in polls in this forum |