XTShellTreeBase issue w/ Windows 7

Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic

   Hello,

I'm seeing an access violation within CXTShellTreeBase::InitTreeViewItems when attempting to expand the "Homegroup" folder on Windows 7.

The crash is easily reproduced - just run any of the CodeJock samples that make use of the shell tree control (WinExplorer, for example) and attempt to expand the "Homegroup" folder. Again, you must be running Windows 7 (this is a new folder not available in previous versions of Windows).

The problem appears to result from improper use of IShellFolder::EnumObjects. Although the return of this method is being checked, LPENUMIDLIST can also be NULL if no suitable subobjects are found (http://msdn.microsoft.com/en-us/library/bb775066%28VS.85%29.aspx). I believe the solution is to check variable "lpe" for NULL after the call to IShellFolder::Enumobjects.

Author	Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic
markr Members Profile Send Private Message Find Members Posts Add to Buddy List Senior Member Joined: 01 August 2004 Status: Offline Points: 443	Post Options Post Reply Quote markr Report Post Thanks(0) Quote Reply Topic: XTShellTreeBase issue w/ Windows 7 Posted: 27 August 2009 at 2:39pm
	Hello, I'm seeing an access violation within CXTShellTreeBase::InitTreeViewItems when attempting to expand the "Homegroup" folder on Windows 7. The crash is easily reproduced - just run any of the CodeJock samples that make use of the shell tree control (WinExplorer, for example) and attempt to expand the "Homegroup" folder. Again, you must be running Windows 7 (this is a new folder not available in previous versions of Windows). The problem appears to result from improper use of IShellFolder::EnumObjects. Although the return of this method is being checked, LPENUMIDLIST can also be NULL if no suitable subobjects are found (http://msdn.microsoft.com/en-us/library/bb775066%28VS.85%29.aspx). I believe the solution is to check variable "lpe" for NULL after the call to IShellFolder::Enumobjects.

Oleg Members Profile Send Private Message Find Members Posts Add to Buddy List Admin Group Joined: 21 May 2003 Location: United States Status: Offline Points: 11234	Post Options Post Reply Quote Oleg Report Post Thanks(0) Quote Reply Posted: 31 August 2009 at 12:30pm
	Hi, Thanks, problem is fixed for next release. you are right - you can patch your sources and check if lpe is not NULL.
	Oleg, Support Team CODEJOCK SOFTWARE SOLUTIONS