Dll embeded FrameWnd wont load menu bar

Hi,

Yes, you need second method but after you load menu, convert this pMenu to pMenuBar:

Okay here is the full solution:

<code>
BOOL CComponentEditorDialog::OnInitDialog()
{
    LoadAccelTable( MAKEINTRESOURCE(IDR_COMPONENT_EDITOR_MENU) );

    CRect rc;
    GetClientRect( &rc );

    HMENU menu = LoadMenu(GetHInstance(),MAKEINTRESOURCE(IDR_COMPONENT_EDITOR_MENU));
    CMenu * pMenu = new CMenu();
    if ( pMenu )
    {
        if ( pMenu->Attach(menu) )
        {
            TRACE0("success created menu bar\n");
        }
        else
        {
            TRACE0("Failed to create menu bar\n");
        }
    }

    try
    {
        if (!InitCommandBars())
        {
            return -1;
        }
    }   
    catch (CResourceException *e)
    {
        e->Delete();
        return -1;
    }

    // Get a pointer to the command bars object.
    CXTPCommandBars* pCommandBars = GetCommandBars();
    if(pCommandBars == NULL)
    {
        TRACE0("Failed to create command bars object.\n");
        return -1;
    }

    CXTPCommandBar * pMenuBar = pCommandBars->Add(_T("Menu Bar"),xtpBarTop); //creates a generic toolbar
    if ( pMenuBar == NULL )
    {
        TRACE0("Failed to create menu bar\n");
    }
    else
    {
        pMenuBar->LoadMenu(pMenu); //then load the menu into it
        pMenuBar->SetFlags(xtpFlagStretched);
        pMenuBar->EnableCustomization(FALSE);
    }

    GetDockingPaneManager()->InstallDockingPanes(this);
    GetDockingPaneManager()->SetTheme(xtpPaneThemeOffice2003);
    GetDockingPaneManager()->SetThemedFloatingFrames(TRUE);
    GetDockingPaneManager()->SetAlphaDockingContext(TRUE);
    GetDockingPaneManager()->SetShowDockingContextStickers(TRUE);

    m_componentGraph.Create(WS_CHILD|WS_CLIPCHILDREN|WS_VISIBLE,rc,this,AFX_IDW_PANE_FIRST);
   
    return TRUE;
}
</code>


So if this is possible through manual loading of the menu and setting, there is a bug in the CXTPCommandBars::SetMenu function which does not look to load the resource from the correct module instance?

below is the GetHInstance function which return the module instance handle for the current module:

<code>
//////////////////////////////////////////////////////////////////////////
HINSTANCE GetHInstance()
{   
    MEMORY_BASIC_INFORMATION mbi;
    CHAR szModule[MAX_PATH];

    SetLastError(ERROR_SUCCESS);
    if (VirtualQuery(GetHInstance,&mbi,sizeof(mbi)))
    {
        if (GetModuleFileName((HINSTANCE)mbi.AllocationBase,szModule,sizeof(szModule)))
        {
            return (HINSTANCE)mbi.AllocationBase;
        }       
    }
    return NULL;
}
</code>

This can then be used to load the resource from, I propose that the CXTPCommandBars::SetMenu function needs to handle the case of loading menu resources from the current module.