CXTPImageManagerIconHandle bug!

Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic

CXTPImageManagerIconHandle foo()
{
    CXTPImageManagerIconHandle hIcon;
    hIcon = ...

    return hIcon; // Destructor called for hIcon
}

hIcon.m_bClearHandles == TRUE... so the returned object will be corrupted. I believe you should use auto_ptr-thinking here!

In copy-constructor and assignment-operator the right-hand-side variable m_bClearHandles should be set to FALSE!

h1 = h2; // h2.m_bClearHandles = FALSE

My solution:
mutable BOOL m_bClearHandles;

CXTPImageManagerIconHandle::CXTPImageManagerIconHandle(const CXTPImageManagerIconHandle& hHandle)

{
    ...
    hHandle.m_bClearHandles = FALSE;
}

Author	Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic
znakeeye Members Profile Send Private Message Find Members Posts Add to Buddy List Senior Member Joined: 26 July 2006 Status: Offline Points: 1672	Post Options Post Reply Quote znakeeye Report Post Thanks(0) Quote Reply Topic: CXTPImageManagerIconHandle bug! Posted: 02 September 2008 at 4:14am
	CXTPImageManagerIconHandle foo() { CXTPImageManagerIconHandle hIcon; hIcon = ... return hIcon; // Destructor called for hIcon } hIcon.m_bClearHandles == TRUE... so the returned object will be corrupted. I believe you should use auto_ptr-thinking here! In copy-constructor and assignment-operator the right-hand-side variable m_bClearHandles should be set to FALSE! h1 = h2; // h2.m_bClearHandles = FALSE My solution: mutable BOOL m_bClearHandles; CXTPImageManagerIconHandle::CXTPImageManagerIconHandle(const CXTPImageManagerIconHandle& hHandle) { ... hHandle.m_bClearHandles = FALSE; }

Oleg Members Profile Send Private Message Find Members Posts Add to Buddy List Admin Group Joined: 21 May 2003 Location: United States Status: Offline Points: 11234	Post Options Post Reply Quote Oleg Report Post Thanks(0) Quote Reply Posted: 08 September 2008 at 3:27am
	Hi, Its'wrong. Don't change it.
	Oleg, Support Team CODEJOCK SOFTWARE SOLUTIONS

znakeeye Members Profile Send Private Message Find Members Posts Add to Buddy List Senior Member Joined: 26 July 2006 Status: Offline Points: 1672	Post Options Post Reply Quote znakeeye Report Post Thanks(0) Quote Reply Posted: 09 September 2008 at 2:43pm
	I disagree. The class is broken since it cannot be returned without destroying the icon.

Oleg Members Profile Send Private Message Find Members Posts Add to Buddy List Admin Group Joined: 21 May 2003 Location: United States Status: Offline Points: 11234	Post Options Post Reply Quote Oleg Report Post Thanks(0) Quote Reply Posted: 09 September 2008 at 2:56pm
	Hi, you can change it but you will get a lot of resource leaks. better change your method to get reference bool foo(CXTPImageManagerIconHandle& out)
	Oleg, Support Team CODEJOCK SOFTWARE SOLUTIONS