CXTCaption::UpdateCaption icon bug

Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic

   I noticed a tiny bug in CXTCaption::UpdateCaption.

Bug occurs when changing icon from "real icon" to "null icon".

In CXTCaption::UpdateCaption are following code:

    if (hIcon != NULL)

    {

        m_hIcon    = hIcon;

        DrawCaptionIcon( pDC, rcClient );

    }

So if given icon is NULL, then CXTCaption::m_hIcon wont be updated and

previous icon will be painted when next update occurs (UpdateCaption seems

to work ok before next paint, because it erases background in UpdateCaption also).

Luckily, UpdateCaption is virtual, so it can be override. But that 

if (hIcon != NULL) should be removed, set m_hIcon outside of

that scope, etc..

[offtopic]

Happy new year!

[/offtopic]

Author	Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic
Kimeli Members Profile Send Private Message Find Members Posts Add to Buddy List Newbie Joined: 14 July 2003 Location: Finland Status: Offline Points: 5	Post Options Post Reply Quote Kimeli Report Post Thanks(0) Quote Reply Topic: CXTCaption::UpdateCaption icon bug Posted: 28 December 2004 at 4:00am
	I noticed a tiny bug in CXTCaption::UpdateCaption. Bug occurs when changing icon from "real icon" to "null icon". In CXTCaption::UpdateCaption are following code: if (hIcon != NULL) { m_hIcon = hIcon; DrawCaptionIcon( pDC, rcClient ); } So if given icon is NULL, then CXTCaption::m_hIcon wont be updated and previous icon will be painted when next update occurs (UpdateCaption seems to work ok before next paint, because it erases background in UpdateCaption also). Luckily, UpdateCaption is virtual, so it can be override. But that if (hIcon != NULL) should be removed, set m_hIcon outside of that scope, etc.. [offtopic] Happy new year! [/offtopic]