|
[solved] v18.0 CXTPSystemVersion::GetComCtlVersion |
Post Reply 
|
| Author | |
MGebler 
Groupie 
Joined: 18 May 2006 Location: Germany Status: Offline Points: 64 |
 Post Options
 Thanks(1)
 Quote Reply
 Topic: [solved] v18.0 CXTPSystemVersion::GetComCtlVersionPosted: 09 August 2017 at 6:31am |
|
I found an implementation error in your latest release:
DWORD CXTPSystemVersion::GetComCtlVersion() const { static DWORD dwVersion = 0; if (0 != dwVersion) { dwVersion = CXTPModuleHandle(_T("comctl32.dll")).GetVersion(); if (0 == dwVersion) dwVersion = MAKELONG(0, 4); // Old ComCtl32 had version 4.0 } return dwVersion; } the correct implementation would be: DWORD CXTPSystemVersion::GetComCtlVersion() const { static DWORD dwVersion = 0; if (0 == dwVersion) { dwVersion = CXTPModuleHandle(_T("comctl32.dll")).GetVersion(); if (0 == dwVersion) dwVersion = MAKELONG(0, 4); // Old ComCtl32 had version 4.0 } return dwVersion; } One effect is that some image lists do not support the alpha channel of icons. Regards Marcus |
|
 |
|
|
olebed
Admin Group 
Joined: 01 July 2014 Location: Ukraine Status: Offline Points: 841 |
Post Options
Thanks(0)
Quote Reply
Posted: 09 August 2017 at 8:01am |
|
Hello Marcus,
We have fixed this yesterday. Other customer on support reported about this bug. I have investigated what it can affect on: - BalloonStyle tooltips not supported. CXTPToolTipContext::IsBalloonStyleSupported() - alpha icons handling CXTPImageManagerResource::Add() -> CXTPImageManager::IsAlphaIconsImageListSupported() - inflate ReBar for 4 px in CXTPReBarBase::_AddBar() - CXTPWinThemeWrapper::IsAppThemeReady() can return FALSE instead of TRUE (used in very many places); - CXTPTaskDialogProgressCtrl drawing - using user defined colors in CXTPTreeBase::GetTreeBackColor() and CXTPTreeBase::GetTreeTextColor() - wrong return value in CXTPAuxData::GetComCtlVersion() - wrong return value in CXTPSkinManager::IsComCtlV6() -> CXTPSkinObjectToolBar::IsAlphaImageList()
Thank you. Oleksandr Lebed |
|
|
|
|
g_j_a_i_n
Groupie
Joined: 27 August 2005 Status: Offline Points: 94 |
Post Options
Thanks(1)
Quote Reply
Posted: 12 September 2017 at 7:58am |
|
This is a silly and serious bug. You need to release a new update as soon as possible. When is next update expected?
|
|
|
|
|
Jebo
Senior Member 
Joined: 27 October 2005 Location: Germany Status: Offline Points: 318 |
Post Options
Thanks(0)
Quote Reply
Posted: 17 October 2017 at 9:08am |
|
In Version 18 it is not possible anymore to use Alpha-Icons from picture-sources...
For example (comparison: Version 15 and Version 18):   As you can see the Alpha-Icons are distorted!!!  Example Source-Code: SourceCode_BUG-Example.zip |
|
|
[Sig removed by Admin: Signature can't exceed 40GB]
|
|
|
|
|
olebed
Admin Group
Joined: 01 July 2014 Location: Ukraine Status: Offline Points: 841 |
Post Options
Thanks(0)
Quote Reply
Posted: 17 October 2017 at 2:09pm |
|
Hi,
We have started to compile all significant fixes in new branch. I hope we will release it soon. Regards, Oleksandr Lebed |
|
|
|
|
rdhd
Senior Member
Joined: 13 August 2007 Location: United States Status: Offline Points: 891 |
Post Options
Thanks(0)
Quote Reply
Posted: 28 November 2017 at 2:37pm |
|
We pulled 18.0.1 and just tracked down the same bug in the code and that led me here via a search. Is this fixed or not? If so, what version?
|
|
|
|
|
olebed
Admin Group
Joined: 01 July 2014 Location: Ukraine Status: Offline Points: 841 |
Post Options
Thanks(0)
Quote Reply
Posted: 28 November 2017 at 2:43pm |
|
Helle rdhd,
This bug fixed in v18.2 Regards, Oleksandr Lebed |
|
|
|
|
Post Reply
|
|
Tweet
|
| Forum Jump | Forum Permissions You cannot post new topics in this forum You cannot reply to topics in this forum You cannot delete your posts in this forum You cannot edit your posts in this forum You cannot create polls in this forum You cannot vote in polls in this forum |
![RSS Feed - [solved] v18.0 CXTPSystemVersion::GetComCtlVersion](forum_images/rss.png "RSS Feed: [solved] v18.0 CXTPSystemVersion::GetComCtlVersion")
Topic Options