[BUG?] XTPControlGallery.cpp(362)

Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic

   XTP 15.1.2
CString strCaption;
if (nId > 0 && strCaption.LoadString(nId)){
    pItem->SetCaption(strCaption);

What if pItem already has a caption? Is the above really correct? (Not to mention that you should always use your own XTPResourceManager()->LoadString().)

I would suggest something like this:

CString strCaption;
if (nId > 0 && pItem->GetCaption().GetLength() == 0 && strCaption.LoadString(nId)){
        pItem->SetCaption(strCaption);

Author	Message Topic Search Topic Options Post Reply Create New Topic Printable Version Translate Topic
znakeeye Members Profile Send Private Message Find Members Posts Add to Buddy List Senior Member Joined: 26 July 2006 Status: Offline Points: 1672	Post Options Post Reply Quote znakeeye Report Post Thanks(0) Quote Reply Topic: [BUG?] XTPControlGallery.cpp(362) Posted: 17 August 2011 at 4:48am
	XTP 15.1.2 CString strCaption; if (nId > 0 && strCaption.LoadString(nId)) { pItem->SetCaption(strCaption); What if pItem already has a caption? Is the above really correct? (Not to mention that you should always use your own XTPResourceManager()->LoadString().) I would suggest something like this: CString strCaption; if (nId > 0 && pItem->GetCaption().GetLength() == 0 && strCaption.LoadString(nId)) { pItem->SetCaption(strCaption);
	PokerMemento - http://www.pokermemento.com/

Oleg Members Profile Send Private Message Find Members Posts Add to Buddy List Admin Group Joined: 21 May 2003 Location: United States Status: Offline Points: 11234	Post Options Post Reply Quote Oleg Report Post Thanks(0) Quote Reply Posted: 24 August 2011 at 8:26am
	Hi, Thanks, good suggestion.
	Oleg, Support Team CODEJOCK SOFTWARE SOLUTIONS