Week view mode title

As near as I can tell something in the "StripFormat" method is clobbering the format string.

This method builds the format strings:

CString CXTPCalendarCaptionBarTheme::CDateLabelPart::_FormatDate(COleDateTime dtDay1, COleDateTime dtDay2, BOOL bShowMonthDay)

You'll see strFormat2 is made from strFormat1 here:

CString strFormat2(strFormat1); << these should be 2 distinct CStrings now. Instead as you'll see code acts like it's one

Removing 'y' from strFormat1 ALSO removes it from strFormat2, clobbering it. This is a minor display bug, but it also indicates something seriously wrong going on. Maybe it's some simple thing but I don't know why it's happening. If you want to fix it temporarily while CJ engineers go mad, stick the 'y' back on strFormat2.

approximately line 1676 in XTPCalendarCaptionBarControl.cpp

strFormat1 = CXTPCalendarUtils::RemoveFormatPart(strFormat1,  _T('y'));
strFormat2.Append(_T("yyyy")); // WHAT!??

>> a small comment to prev post:
CString strFormat2(strFormat1); //this is 2 distinct CStrings now - Surprise you don't understand it.
                                              Removing 'y' from strFormat1 NOT removed it from strFormat2.
                                             Try to Debug this piece of code if you not trust CString constructor. <<

With all due respect mdoubson, that was my point. They are 2 distinct strings yet the code is "acting" as if they are one. I watched it in the debugger and when strFormat1 was stripped, it also stripped strFormat2. The CString constructor worked fine. I haven't had a chance to play with it further since I do have other tasks but it acts like a memory overwrite. The proof was in the display and in the debugger. Has anyone at CJ tried or been able to duplicate the bug? Maybe it's a peculiarity of a certain build environment or properties.

This effect can also be seen in the demo so its nothing unique with my code.

Compiled with VS 2005. Static Unicode.

After:

Correct. When the yyyy is stripped from strFormat1 it also strips it from strFormat2 and leaves the comma in strFormat2. The display in the caption bar shows this as well. It shows something like: July 3 - July 10, 

If the error is never produced while scrolling, then it must be either the compiler or the build. I see nothing obvious in the code that is producing the error or I would have fixed it a long time ago. When the strip method returns strFormat1, strFormat2 is also changed.

VS 2005 using static, unicode definitely fails.

Perhaps someone can configure a 2005 build and see what they get. As you can see, it can be reproduced using week or month modes.

This is current (after official 13.1 release) MFC Calendar source updates: https://forum.codejock.com/uploads/DemoVersion/CalendarControlMFCUpdated.rar

I don't understand the term improved here - is it working or not?

Right - so the problem is in some local settings - for XP-RU everything is proper. I will switch to XP-EN and give you know

It now works properly in my builds.

Thank you for the fix.