global toolbar button image replacement

 

 

 

 

 

 

Telling the toolbars not to load any icons doesn't really help, because I would then NEED to load ALL the icons for ALL the toolbars at startup.

 

What I want to do is have each toolbar load as normal, but if we decide to replace an icon for a command that is used in more than one toolbar, for instance the "refresh" icon, we can just pre-load this at start up and all toolbars with this command will still load all their icons as normal, except they won't replace this one pre-loaded icon.

 

Adding an option to CXTPImageManager to tell it not to overwrite existing icons would allow this to work.  Alternatively, making some of the class's functions virtual would allow me to do this in my own override.

 

I want all buttons with the same ID to have the same icon, but I want to be able to change that icon in just one place.  So instead of modifying all the toolbars that have the "refresh" command to use a new icon, I would just set the new icon for the refresh command's ID in the image manager at application start up.  Then when each toolbar is loaded, it would see that there is already an icon for that command ID and not replace it with the (old) image from the toolbar's button. 

 

As I said to Oleg, I don't want to HAVE to load ALL the icons for ALL the toolbars at startup, I want the toolbars to load all their own icons as normal, EXCEPT for any command icons that I choose to pre-load at startup, that way I can replace just some icons as and when I like without having to edit every toolbar or load ALL the icons at startup.

 

If there was an option in the CXTPImageManager class to prevent existing images being overwritten, this would work.  I could load any "new" icons that I want to use into the image manager at startup, set the option to prevent images being ovewritten, and allow toolbars to load as normal.  Then when the toolbar loads, all it's icons for the commands would be loaded as normal, EXCEPT for the "new" ones which I already loaded at statup, thus I would have replaced these icons in ALL the toolbars without having had to edit any of them.

 

Replacing whole image sets could be done, as you and Oleg have suggested, by preventing the toolbars from loading any images at all and instead loading them ALL at startup, but this lacks the flexibilty to replace just some specific icons.  It also means that we have to ensure that every piece of code that loads a toolbar passes FALSE for the "load icons" option, and that there is an icon loaded for every command button at startup - not a big deal but the fewer places you need to change code the less chance of making mistakes.

 

Having the option I've suggested for CXTPImageManager keeps all the changes in one place, toolbar loading code does not have to change, and if we forget to add a new icon for any command the original toolbar icon will still be used.